Repository navigation
Add a cover-art loading screen, installer splash and legal notes - #1
Merged
Merged
Conversation
Levels load in stages behind the cover art with a progress bar and scrolling tips. The cover art is also the boot splash. The UI uses canvas_items stretch with expand, so menus, How to Play and the HUD fit 4:3, 16:9 and ultrawide windows, and render scale follows the window's physical height.
The installer opens with a cover-art splash, uses the art on the welcome and finish pages, and shows it beside a tips box that slides to a new tip at each install step. The bitmaps are cut from the cover art at build time. Adds the MIT licence and LEGAL.md covering every shipped asset and build tool, and rewrites the README with the story, per-platform install steps and build and test instructions. The bundled credits now state the game licence and fiction notice, and record that Piper 1.8.0 is GPL-3.0-or-later (build tool only) and that the joe voice clips are excluded from MIT because of their training data.
Uses the official Godot 4.7.2 Linux build, pinned by SHA-512, to run the gameplay suite and level validation, and runs the packaging tests with the pinned Python requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Levels were built synchronously in
_ready, so there was nothing to look at while one loaded, and the installer was the stock NSIS wizard. This puts the new cover art throughout. It is the boot splash, then the background of a loading screen that builds the level in stages behind it, with an orange progress bar and tips that scroll up every few seconds. The installer opens with a fading cover-art splash and uses the art on its welcome and finish pages. While files copy, it shows the art beside a tips box that slides to a new tip at each install step. I also switched the UI tocanvas_itemsstretch withexpand. The menus, How to Play (now scrollable), level select and HUD fit 4:3, 16:9 and ultrawide windows, and the 3D render scale follows the window's physical height rather than the stretched canvas.With the repo public, the legal side needed writing down.
LICENSEis MIT for the original code and content.LEGAL.mdlists every shipped asset and build tool with its licence and notice file, along with voice provenance, the fiction and trademark notes and a privacy statement. Checking the tools turned up two things:joevoice is fine-tuned from Piper'slessacvoice, whose Blizzard 2013 training data is licensed for research only. So the 31joe_*.wavclips are excluded from MIT and should be regenerated with another voice before anything commercial.The bundled credits now say both. CI runs the Godot suites on the official 4.7.2 Linux build, pinned by SHA-512, plus the new packaging tests.
I verified this on Windows 11 with Godot 4.7.2:
test_level.gdpasses 152/152, including new checks that staged loading reaches 100% before handing over to the menu and that the tips rotate.test_levels.gdpasses 994/994 across all 11 levels.pytest tools/packagingpasses 3/3.test_level.gd./TESTMODEand captured the splash, the progress page with art and tips, and the finish page./S /TESTMODEinstall matched all 28 package files by hash and left the registry untouched. The installed game started headless with exit 0, and the uninstaller removed everything.The Linux and macOS builds still have not run on real hardware, and the installer is unsigned.
Happy to adjust. -MB