Repository navigation
Voice Exitwell with a public-domain voice and check installs on Linux and macOS - #2
Merged
Merged
Conversation
The joe voice was fine-tuned from Piper's lessac voice, whose training data is licensed for research only. Exitwell's 15 story lines are regenerated with norman (LibriVox, trained from scratch) at a slightly higher pitch, the exosuit boss and helicopter leader use norman's existing shouts, and the 31 joe clips and model files are removed. A new check fails if any clip uses a voice outside the public-domain list.
Every voice clip is now MIT, so the joe exceptions come out of the credits, asset manifest, README and LEGAL.md. LEGAL.md records the release licence review, and the credits add the FreeType and Independent JPEG Group acknowledgements their licences require. The README and a GitHub Sponsor button link to the NBCF fundraising page. The build now removes the temporary copy Windows can leave beside YNGM.exe after the icon update, refuses to compile the installer if the package holds anything unexpected, and refreshes the bundled licences instead of merging into old ones.
On every published release, the workflow downloads the Linux and macOS packages and checks their hashes against dist/build-result.json. On Ubuntu 24.04 it runs install.sh, launches the game headless and in an Xvfb window, and uninstalls. On macOS 15 Apple Silicon and Intel runners it installs to Applications, verifies the signature, architectures and version, and launches the app headless and through open. Screenshots and logs are kept as artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preston Exitwell's lines, the exosuit boss and the helicopter leader used Piper's
joevoice. That voice was fine-tuned fromlessac, whose Blizzard 2013 training data is licensed for research only, so 1.0.0 had to carve 31 clips out of MIT. I regenerated Exitwell's 15 story lines withnorman(public-domain LibriVox, trained from scratch) and pitched him up slightly to set him apart from Lance Upround. The boss and helicopter now usenorman's existing shouts, and thejoeclips and model files are gone. Exitwell was the obvious one to move: he never shares a level with Upround, but he shares the ending and level 11 with OMEGA, which usesjohn. Almost every other male Piper voice is either fine-tuned fromlessacor trained on a non-commercial dataset, so these three are the only fully clean choices. A new check intest_level.gdfails if any clip uses a voice outside that list.With that, everything in the release is under an open licence. I went through each shipped component against its source:
LEGAL.md.LEGAL.mdrecords the review. The README now leads with a link to my NBCF fundraiser, using NBCF's community supporter wording and making clear the game isn't run by them;.github/FUNDING.ymladds the same link as the Sponsor button. The build drops a temporary copy ofYNGM.exethat Windows had left beside it, which had bloated the installer to 140 MB. It now also refuses to package anything unexpected. The version is bumped to 1.0.1.release-install.ymlinstalls each published release on clean runners:install.sh, the menu entry, a headless launch, a windowed launch under Xvfb with a screenshot, then uninstall.codesign,lipo, the plist version, a headless launch and anopenlaunch.On this PR it runs against the latest release (1.0.0) so the workflow itself is exercised before 1.0.1 ships.
I verified this on Windows 11 with Godot 4.7.2:
test_level.gdpasses 152/152, including the new voice check. I also confirmed that check fails when a strayjoe_clip is dropped in.test_levels.gdpasses 994/994, andpytest tools/packagingpasses 3/3.test_level.gd./S /TESTMODEinstall of the 1.0.1 installer matched all 26 files by hash. The installed game ran with exit 0, and the uninstaller removed everything.Gatekeeper's first-launch prompt can't be exercised on CI, because files downloaded by
gharen't quarantined.Happy to adjust. -MB