Harden settings deserialisation against corrupt or partial data#24
Merged
Harden settings deserialisation against corrupt or partial data#24
Conversation
Owner
MBurchard
commented
Mar 27, 2026
MBurchard
commented
- Add lenient_option deserializer that returns None for type mismatches instead of failing the entire settings file
- Make all WindowSettings and GameUiSettings fields nullable (Option) so missing or corrupt values degrade gracefully
- Window restore handles partial data: position and size are restored independently, either can be absent
- HintSettings.minimize_to_tray stays u32 with default 0 (internal counter, not user-facing)
- Add lenient_option deserializer that returns None for type mismatches instead of failing the entire settings file - Make all WindowSettings and GameUiSettings fields nullable (Option<T>) so missing or corrupt values degrade gracefully - Window restore handles partial data: position and size are restored independently, either can be absent - HintSettings.minimize_to_tray stays u32 with default 0 (internal counter, not user-facing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.