Add job queue auto-expand and harden all hook functions#31
Merged
Conversation
- Add auto_expand_job_queue setting across all layers (backend, mod, frontend toggle in SettingsView) - Hook RegenerateLists() as instance-capture trigger for the job queue panel (non-virtual, avoids IL2CPP generic sharing) - Add null-guards on original function pointers in all hook callbacks to prevent null-dereference during installation - Wrap custom hook logic in catch_unwind where missing (chat_frame, spacebar) to prevent panics crossing FFI boundary - Consolidate redundant original-pointer resolution in player_prefs hooks (one load at entry instead of per-branch) - Remove unused LogLevelScopes fields: backend drops `game`, mod drops `app` (serde ignores unknown TOML sections) - Document JobQueue log target in log-levels.md
- Add LogLevelScopes struct to AppSettings so [log_levels.game] and [log_levels.app] sections in settings.toml survive load/save round-trips - Previously, saving any setting (e.g. toggling auto_open_sidebar) would silently drop manually configured per-target log levels - Omit the section entirely when no overrides are configured - Add round-trip and omission tests
- Hook UIFrameManager.OnEnable to capture the manager instance. The previous ShowSideFrame hook was never called on Windows, not even manually. - Call ResizeSideFrame directly on the captured instance after the click, instead of the indirect PENDING_WIDTH mechanism via ShowSideFrame. - Use GetMaxSideFrameWidth to query the game's actual maximum instead of blindly passing 2000.0 and hoping the game clamps. Falls back to 2000.0 if unavailable. - try_restore now requires three conditions: ChatPreviewController active, UIFrameManager captured, and settings synced. Any of the three can arrive last.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
game, mod dropsapp(serde ignores unknown TOML sections)