feat(scoring): Phase 3c attack graph polish#284
Merged
Conversation
Add FixKind registry resolution, optional counterfactual remediation and path compression, dashboard layer filters with policy/inferred edge styling, and doctor --suggest-fixes for template remediations from scan reports.
…ults) Apply FixKind registry mutates at runtime with template re-match simulation, attach inventory-layer cross-server edges when fleet inventory is present, and enable counterfactuals plus UI path compression by default with CLI opt-out.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #286
Summary
fixes/registry.yaml+graph_fixes.py; templaterecommended_fixeson every matched pathgraph_mutate.pyapplies registrymutates, re-matches templates, and reportsfix_simulation/effective_fixeson counterfactual payloadsgraph_inventory.pyattachesinventorylayer cross-server edges (W015 read→write, W016 tool shadow) when fleet inventory ≥2--no-attack-graph-counterfactualsto disable); trust-layer-shaped remediation on template findings--no-attack-graph-compress-ui); dedupes/caps paths in report export for dashboard readabilitymcts doctor --suggest-fixes --report scan.jsonlists template remediations from a prior scanTest plan
uv run pytest tests/scoring/test_graph_phase_3c.py— 14 passeduv run ruff check+ruff format --checkuv run python scripts/run_regression.py --strict --servers-root tests/fixtures/monorepo-mini— R-01–R-25 pass