Conversation
Major update to align with the current Philote protocol: - VariableMessage oneof wrapper replaces raw Array streaming - Discrete variable support (non-numeric inputs/outputs via protobuf Value) - Dynamic shapes (runtime-resolved variable dimensions, SetVariableShapes RPC) - RPC timeout support on client - Configure() lifecycle method in discipline trait - Backward-compatible trait design with default method implementations - Updated proto definitions from Philote-Cpp
Brings in discrete variable support, kStruct data type, dynamic variable shapes, and the SetVariableShapes RPC.
Replace 6 reusable workflow files with a consolidated tests.yaml, add label-driven release.yaml and publish-crates.yaml workflows mirroring Philote-Python. Rename crate to philote-mdo with full crates.io metadata and proto file inclusion for packaging.
The release workflow will bump this to 0.1.0 on the first minor release.
tonic requires Status as the error type for gRPC services, which exceeds clippy's size threshold. This is not something we can change.
Codecov couldn't find the repo because the remote still uses the old chrislupp/Philote-Rust URL. Explicit slug resolves the lookup.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
philotetophilote-mdowith full crates.io metadataChanges
tests.yaml(fmt, clippy, build, test, coverage)release.yamltriggered on PR merge with release labels (handles version bump, changelog, tagging, GitHub Release, merge-back to develop)publish-crates.yamltriggered on GitHub Release (publishes to crates.io)philote→philote-mdowithincludefield for proto filesTest plan
cargo publish --dry-runsucceedscargo package --listconfirms proto files are included