Added test input data files and modified MEF package in the test directory#8
Open
krishna1803 wants to merge 1 commit into
Open
Added test input data files and modified MEF package in the test directory#8krishna1803 wants to merge 1 commit into
krishna1803 wants to merge 1 commit into
Conversation
mjethanandani
requested changes
Oct 5, 2018
mjethanandani
left a comment
mjethanandani
left a comment
Contributor
There was a problem hiding this comment.
Krishna, thank you first of all for updating the examples and putting them together. It would help to know how to run the tests for folks who are new to the repository. Can you update the README at the top of the repository to update -
- information on what tests are being run.
- how to run them.
Thanks
| @@ -0,0 +1,308 @@ | |||
| module ietf-network-topology { | |||
Contributor
There was a problem hiding this comment.
Why is this model being added to this repository? At best it should be downloaded on demand, and failing that manually downloaded before starting the test.
| @@ -0,0 +1,204 @@ | |||
| module ietf-network { | |||
| <layer-protocol-name xmlns="urn:onf:params:xml:ns:yang:TapiTopology">eth</layer-protocol-name> | ||
| </node> | ||
| </network> | ||
| <!--network xmlns="urn:ietf:params:xml:ns:yang:ietf-network"> |
Contributor
There was a problem hiding this comment.
Please keep original indentation format (of 2 spaces).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.