Skip to content

Support hexad player type event - #66

Merged
MP-DG merged 4 commits into
mainfrom
support-HexadPlayerType-event
Dec 17, 2025
Merged

MP-DG merged 4 commits into
mainfrom
support-HexadPlayerType-event

Conversation

@MP-DG

@MP-DG MP-DG commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Description of changes

Gamification Service now informs other services of the Player Type of the users.

  • sends UserHexadPlayerTypeSet event when the PlayerType is evaluated
  • listens to RequestHexadPlayerTypeEvent and sends UserHexadPlayerTypeSet event

How has this been tested?

Please describe the test strategy you followed. If not tested, please explain why.

  • automated unit test
  • automated integration test
  • manual, exploratory test

In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.

Checklist before requesting a review

  • My code is easy to understand
  • My code follows the coding guidelines of this project
  • My code fulfills all acceptance criteria
  • The test coverage (line and branch) is reasonably high, especially on Service classes and other classes with complex logic
  • I have made corresponding changes to the documentation or
    the wiki/adr
  • I made no breaking changes in the database schema or if so, I will perform a database migration

Checklist for reviewer

  • The code is easy to understand
  • The code follows
    the coding guidelines of
    this project
  • The code is tested or if not, the reason is documented or discussed
  • The added and existing tests reasonably cover the code change
  • The code has no breaking changes in the database schema or if so, the assignee is aware of it and
    will perform a database migration

@c-neli-r c-neli-r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Für mich macht der Code einen sehr aufgeräumten und gut strukturierten Eindruck. Ich bin inhaltlich allerdings nicht wirklich in deiner Bachelorarbeit drin, und für die vielen Änderungen war die Zeit zum Durchschauen etwas knapp. Wenn aber alles sauber läuft, würde ich dir auf jeden Fall mein Okay geben.

@MP-DG
MP-DG merged commit 5423714 into main Dec 17, 2025
3 checks passed
@MP-DG
MP-DG deleted the support-HexadPlayerType-event branch December 17, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants