Skip to content

Dapr events processing - #11

Merged
JonathanWolp merged 13 commits into
mainfrom
Dapr-events-processing
Oct 4, 2025
Merged

JonathanWolp merged 13 commits into
mainfrom
Dapr-events-processing

Conversation

@lVentus

@lVentus lVentus commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Description of changes

Please provide a short description of the change or if the change is sufficiently described in the GitHub issue, provide a link to the issue.

How has this been tested?

Please describe the test strategy you followed. If not tested, please explain why.

  • automated unit test
  • automated integration test
  • manual, exploratory test

In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.

Checklist before requesting a review

  • My code is easy to understand
  • My code follows the coding guidelines of this project
  • My code fulfills all acceptance criteria
  • The test coverage (line and branch) is reasonably high, especially on Service classes and other classes with complex logic
  • I have made corresponding changes to the documentation or
    the wiki/adr
  • I made no breaking changes in the database schema or if so, I will perform a database migration

Checklist for reviewer

  • The code is easy to understand
  • The code follows
    the coding guidelines of
    this project
  • The code is tested or if not, the reason is documented or discussed
  • The added and existing tests reasonably cover the code change
  • The code has no breaking changes in the database schema or if so, the assignee is aware of it and
    will perform a database migration

@JonathanWolp JonathanWolp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Database migration missing, risk of data loss/incompatibility
  • External service dependencies (Course/User Settings) can break functionality
  • GraphQL API is not backward-compatible, may break clients
  • Event ingestion relies on Dapr setup—potential for undelivered notifications
  • Live streaming is in-memory only, risk of event loss on restarts
  • No end-to-end/integration tests for full notification flow
  • Permissions/security checks are unclear, possible vulnerabilities

@JonathanWolp JonathanWolp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No migration needed, new service only. External dependencies and permissions implemented. Please add E2E tests soon. Approved for merge.

@JonathanWolp
JonathanWolp merged commit 494e3f7 into main Oct 4, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants