Skip to content

Fix 200 status error response for refreshing access tokens - #23

Merged
Morphenoed merged 8 commits into
mainfrom
schurpl-testing
Aug 23, 2025
Merged

Morphenoed merged 8 commits into
mainfrom
schurpl-testing

Conversation

@Morphenoed

@Morphenoed Morphenoed commented Aug 18, 2025 •

Copy link
Copy Markdown
Contributor

Description of changes

Fix the issue with GH when refreshing access tokens. Sometimes instead of the correct response one gets 200 bad_refresh_token response, see https://github.com/orgs/community/discussions/24745.

How has this been tested?

  • automated unit test
  • automated integration test
  • manual, exploratory test

In case of manual test, please document the test well including a set of user instructions and prerequisites. Each including an action, it's result, and where appropriate a screenshot.

Checklist before requesting a review

  • My code is easy to understand
  • My code follows the coding guidelines of this project
  • My code fulfills all acceptance criteria
  • The test coverage (line and branch) is reasonably high, especially on Service classes and other classes with complex logic
  • I have made corresponding changes to the documentation or
    the wiki/adr
  • I made no breaking changes in the database schema or if so, I will perform a database migration

Checklist for reviewer

  • The code is easy to understand
  • The code follows
    the coding guidelines of
    this project
  • The code is tested or if not, the reason is documented or discussed
  • The added and existing tests reasonably cover the code change
  • The code has no breaking changes in the database schema or if so, the assignee is aware of it and
    will perform a database migration

@Morphenoed
Morphenoed requested a review from myluki2000 August 18, 2025 18:23
@Morphenoed Morphenoed self-assigned this Aug 18, 2025
@Morphenoed
Morphenoed merged commit c1538c3 into main Aug 23, 2025
2 of 3 checks passed
@Morphenoed
Morphenoed deleted the schurpl-testing branch August 23, 2025 12:12
@Morphenoed
Morphenoed restored the schurpl-testing branch August 23, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants