Skip to content

post_process never broadcasts chem_wrt_Y: silent wrong species output on multi-rank chemistry post-processing #1558

Description

@sbryngelson

Symptom: multi-rank chemistry post-processing silently drops or garbles species (Y_*) output on ranks != 0.

Mechanism: chem_wrt_Y is namelist-read (rank 0 only) and consumed on all ranks by s_save_data (src/post_process/m_start_up.fpp:292 on current master), but it is absent from s_mpi_bcast_user_inputs in src/post_process/m_mpi_proxy.fpp — its sibling chem_wrt_T is in the logical broadcast list, chem_wrt_Y is not. Non-root ranks always see the default.

Introduced: #544 (17eb3def8, 2024-09-16, @henryleberre) added the namelist binding and consumption but only updated the simulation proxy. #829 later fixed chem_wrt_T and missed chem_wrt_Y. Tagging @henryleberre for context as the original author.

Fix: #1552 replaces the hand-maintained broadcast lists with registry-generated ones (generated_bcast.fpp), which closes this by construction — a registered namelist parameter is broadcast or the generator is wrong.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions