Shell completion auto-install and pre-commit hook improvements

.github/Dockerfile

@@ -50,16 +50,16 @@ RUN python3.12 -m venv /opt/MFC/build/venv && \
 RUN echo "TARGET=$TARGET CC=$CC_COMPILER FC=$FC_COMPILER" && \
     cd /opt/MFC && \
     if [ "$TARGET" = "gpu" ]; then \
-      ./mfc.sh build --gpu -j $(nproc); \
+      ./mfc.sh build -v --gpu -j $(nproc); \
     else \
-      ./mfc.sh build -j $(nproc); \
+      ./mfc.sh build -v -j $(nproc); \
     fi
 
 RUN cd /opt/MFC && \
     if [ "$TARGET" = "gpu" ]; then \
-      ./mfc.sh test -a --dry-run --gpu -j $(nproc); \
+      ./mfc.sh test -v -a --dry-run --gpu -j $(nproc); \
     else \
-      ./mfc.sh test -a --dry-run -j $(nproc); \
+      ./mfc.sh test -v -a --dry-run -j $(nproc); \
     fi
 
 WORKDIR /opt/MFC

.github/workflows/bench.yml

@@ -1,87 +1,85 @@
 name: 'Benchmark'
 
 on:
-  pull_request:
-  pull_request_review:
-    types: [submitted]
+  # Trigger when Test Suite completes (no polling needed)
+  workflow_run:
+    workflows: ["Test Suite"]
+    types: [completed]
   workflow_dispatch:
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
+  group: ${{ github.workflow }}-${{ github.event.workflow_run.head_branch || github.ref }}
   cancel-in-progress: true
 
 jobs:
   file-changes:
     name: Detect File Changes
+    # Only run if Test Suite passed (or manual dispatch)
+    if: github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success'
     runs-on: 'ubuntu-latest'
     outputs:
       checkall: ${{ steps.changes.outputs.checkall }}
+      pr_number: ${{ steps.pr-info.outputs.pr_number }}
+      pr_approved: ${{ steps.pr-info.outputs.approved }}
+      pr_author: ${{ steps.pr-info.outputs.author }}
     steps:
       - name: Clone
         uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.workflow_run.head_sha || github.sha }}
 
       - name: Detect Changes
         uses: dorny/paths-filter@v3
         id: changes
         with:
           filters: ".github/file-filter.yml"
 
-  wait-for-tests:
-    name: Wait for Test Suite
-    runs-on: ubuntu-latest
-    steps:
-      - name: Wait for Test Suite to Pass
+      - name: Get PR Info
+        id: pr-info
         env:
           GH_TOKEN: ${{ github.token }}
         run: |
-          echo "Waiting for Test Suite workflow to complete..."
-          SHA="${{ github.event.pull_request.head.sha || github.sha }}"
-
-          # Poll every 60 seconds for up to 3 hours
-          for i in $(seq 1 180); do
-            # Get the Test Suite workflow runs for this commit
-            STATUS=$(gh api repos/${{ github.repository }}/commits/$SHA/check-runs \
-              --jq '.check_runs[] | select(.name == "Lint Gate") | .conclusion' | head -1)
-
-            if [ "$STATUS" = "success" ]; then
-              echo "Lint Gate passed. Checking test jobs..."
-
-              # Check if any Github test jobs failed
-              FAILED=$(gh api repos/${{ github.repository }}/commits/$SHA/check-runs \
-                --jq '[.check_runs[] | select(.name | startswith("Github")) | select(.conclusion == "failure")] | length')
-
-              if [ "$FAILED" != "0" ]; then
-                echo "::error::Test Suite has failing jobs. Benchmarks will not run."
-                exit 1
+          if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
+            echo "pr_number=" >> $GITHUB_OUTPUT
+            echo "approved=true" >> $GITHUB_OUTPUT
+            echo "author=${{ github.actor }}" >> $GITHUB_OUTPUT
+          else
+            # Get PR number from workflow_run
+            PR_NUMBER="${{ github.event.workflow_run.pull_requests[0].number }}"
+            if [ -n "$PR_NUMBER" ]; then
+              echo "pr_number=$PR_NUMBER" >> $GITHUB_OUTPUT
+
+              # Fetch actual PR author from API (workflow_run.actor is the re-runner, not PR author)
+              PR_AUTHOR=$(gh api repos/${{ github.repository }}/pulls/$PR_NUMBER --jq '.user.login')
+              echo "author=$PR_AUTHOR" >> $GITHUB_OUTPUT
+
+              # Check if PR is approved
+              APPROVED=$(gh api repos/${{ github.repository }}/pulls/$PR_NUMBER/reviews \
+                --jq '[.[] | select(.state == "APPROVED")] | length')
+              if [ "$APPROVED" -gt 0 ]; then
+                echo "approved=true" >> $GITHUB_OUTPUT
+              else
+                echo "approved=false" >> $GITHUB_OUTPUT
               fi
-
-              # Check if Github tests are still running
-              PENDING=$(gh api repos/${{ github.repository }}/commits/$SHA/check-runs \
-                --jq '[.check_runs[] | select(.name | startswith("Github")) | select(.conclusion == null)] | length')
-
-              if [ "$PENDING" = "0" ]; then
-                echo "All Test Suite jobs completed successfully!"
-                exit 0
-              fi
-
-              echo "Tests still running ($PENDING pending)..."
-            elif [ "$STATUS" = "failure" ]; then
-              echo "::error::Lint Gate failed. Benchmarks will not run."
-              exit 1
             else
-              echo "Lint Gate status: ${STATUS:-pending}..."
+              echo "pr_number=" >> $GITHUB_OUTPUT
+              echo "approved=false" >> $GITHUB_OUTPUT
+              echo "author=" >> $GITHUB_OUTPUT
             fi
-
-            sleep 60
-          done
-
-          echo "::error::Timeout waiting for Test Suite to complete."
-          exit 1
+          fi
 
   self:
     name: "${{ matrix.name }} (${{ matrix.device }}${{ matrix.interface != 'none' && format('-{0}', matrix.interface) || '' }})"
-    if: ${{ github.repository=='MFlowCode/MFC' && needs.file-changes.outputs.checkall=='true' && ((github.event_name=='pull_request_review' && github.event.review.state=='approved') || (github.event_name=='pull_request' && (github.event.pull_request.user.login=='sbryngelson' || github.event.pull_request.user.login=='wilfonba'))) }}
-    needs: [file-changes, wait-for-tests]
+    if: >
+      github.repository == 'MFlowCode/MFC' &&
+      needs.file-changes.outputs.checkall == 'true' &&
+      (
+        github.event_name == 'workflow_dispatch' ||
+        needs.file-changes.outputs.pr_approved == 'true' ||
+        needs.file-changes.outputs.pr_author == 'sbryngelson' ||
+        needs.file-changes.outputs.pr_author == 'wilfonba'
+      )
+    needs: [file-changes]
     strategy:
       fail-fast: false
       matrix:
@@ -145,6 +143,7 @@ jobs:
       - name: Clone - PR
         uses: actions/checkout@v4
         with:
+          ref: ${{ github.event.workflow_run.head_sha || github.sha }}
           path: pr
 
       - name: Clone - Master

.github/workflows/coverage.yml

@@ -39,10 +39,10 @@ jobs:
                 libfftw3-dev libhdf5-dev libblas-dev liblapack-dev
 
       - name: Build
-        run: /bin/bash mfc.sh build -j $(nproc) --gcov
+        run: /bin/bash mfc.sh build -v -j $(nproc) --gcov
 
       - name: Test
-        run: /bin/bash mfc.sh test -a -j $(nproc)
+        run: /bin/bash mfc.sh test -v -a -j $(nproc)
 
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v4

.github/workflows/frontier/bench.sh

@@ -16,7 +16,7 @@ if [ "$job_device" = "gpu" ]; then
 fi
 
 if [ "$job_device" = "gpu" ]; then
-    ./mfc.sh bench --mem 12 -j $n_ranks -o "$job_slug.yaml" -- -c frontier $device_opts -n $n_ranks
+    ./mfc.sh bench -v --mem 12 -j $n_ranks -o "$job_slug.yaml" -- -c frontier $device_opts -n $n_ranks
 else
-    ./mfc.sh bench --mem 1 -j $(nproc) -o "$job_slug.yaml" -- -c frontier $device_opts -n $n_ranks
+    ./mfc.sh bench -v --mem 1 -j $(nproc) -o "$job_slug.yaml" -- -c frontier $device_opts -n $n_ranks
 fi

.github/workflows/frontier/build.sh

@@ -18,9 +18,9 @@ fi
 if [ "$run_bench" == "bench" ]; then
     for dir in benchmarks/*/; do
         dirname=$(basename "$dir")
-        ./mfc.sh run "$dir/case.py" --case-optimization -j 8 --dry-run $build_opts
+        ./mfc.sh run -v "$dir/case.py" --case-optimization -j 8 --dry-run $build_opts
     done
 else
-    ./mfc.sh test -a --dry-run --rdma-mpi -j 8 $build_opts
+    ./mfc.sh test -v -a --dry-run --rdma-mpi -j 8 $build_opts
 fi
 

.github/workflows/frontier/test.sh

@@ -14,7 +14,7 @@ if [ "$job_device" = "gpu" ]; then
 fi
 
 if [ "$job_device" = "gpu" ]; then
-    ./mfc.sh test -a --rdma-mpi --max-attempts 3 -j $ngpus $device_opts -- -c frontier
+    ./mfc.sh test -v -a --rdma-mpi --max-attempts 3 -j $ngpus $device_opts -- -c frontier
 else
-    ./mfc.sh test -a --max-attempts 3 -j 32 --no-gpu -- -c frontier
+    ./mfc.sh test -v -a --max-attempts 3 -j 32 --no-gpu -- -c frontier
 fi

.github/workflows/frontier_amd/bench.sh

@@ -16,7 +16,7 @@ if [ "$job_device" = "gpu" ]; then
 fi
 
 if [ "$job_device" = "gpu" ]; then
-    ./mfc.sh bench --mem 12 -j $n_ranks -o "$job_slug.yaml" -- -c frontier_amd $device_opts -n $n_ranks
+    ./mfc.sh bench -v --mem 12 -j $n_ranks -o "$job_slug.yaml" -- -c frontier_amd $device_opts -n $n_ranks
 else
-    ./mfc.sh bench --mem 1 -j $(nproc) -o "$job_slug.yaml" -- -c frontier_amd $device_opts -n $n_ranks
+    ./mfc.sh bench -v --mem 1 -j $(nproc) -o "$job_slug.yaml" -- -c frontier_amd $device_opts -n $n_ranks
 fi

.github/workflows/frontier_amd/build.sh

@@ -18,9 +18,9 @@ fi
 if [ "$run_bench" == "bench" ]; then
     for dir in benchmarks/*/; do
         dirname=$(basename "$dir")
-        ./mfc.sh run "$dir/case.py" --case-optimization -j 8 --dry-run $build_opts
+        ./mfc.sh run -v "$dir/case.py" --case-optimization -j 8 --dry-run $build_opts
     done
 else
-    ./mfc.sh test -a --dry-run -j 8 $build_opts
+    ./mfc.sh test -v -a --dry-run -j 8 $build_opts
 fi
 

.github/workflows/frontier_amd/test.sh

@@ -14,7 +14,7 @@ if [ "$job_device" = "gpu" ]; then
 fi
 
 if [ "$job_device" = "gpu" ]; then
-    ./mfc.sh test -a  --max-attempts 3 -j $ngpus $device_opts -- -c frontier_amd
+    ./mfc.sh test -v -a  --max-attempts 3 -j $ngpus $device_opts -- -c frontier_amd
 else
-    ./mfc.sh test -a --max-attempts 3 -j 32 --no-gpu -- -c frontier_amd
+    ./mfc.sh test -v -a --max-attempts 3 -j 32 --no-gpu -- -c frontier_amd
 fi

.github/workflows/phoenix/bench.sh

@@ -24,9 +24,9 @@ mkdir -p $currentdir
 export TMPDIR=$currentdir
 
 if [ "$job_device" = "gpu" ]; then
-    ./mfc.sh bench --mem 12 -j $(nproc) -o "$job_slug.yaml" -- -c phoenix-bench $device_opts -n $n_ranks
+    ./mfc.sh bench -v --mem 12 -j $(nproc) -o "$job_slug.yaml" -- -c phoenix-bench $device_opts -n $n_ranks
 else
-    ./mfc.sh bench --mem 1 -j $(nproc) -o "$job_slug.yaml" -- -c phoenix-bench $device_opts -n $n_ranks
+    ./mfc.sh bench -v --mem 1 -j $(nproc) -o "$job_slug.yaml" -- -c phoenix-bench $device_opts -n $n_ranks
 fi
 
 sleep 10

.github/workflows/phoenix/test.sh

@@ -10,7 +10,7 @@ if [ "$job_device" = "gpu" ]; then
     fi
 fi
 
-./mfc.sh test --dry-run -j 8 $build_opts
+./mfc.sh test -v --dry-run -j 8 $build_opts
 
 n_test_threads=8
 
@@ -21,5 +21,5 @@ if [ "$job_device" = "gpu" ]; then
     n_test_threads=`expr $gpu_count \* 2`
 fi
 
-./mfc.sh test --max-attempts 3 -a -j $n_test_threads $device_opts -- -c phoenix
+./mfc.sh test -v --max-attempts 3 -a -j $n_test_threads $device_opts -- -c phoenix
 

.github/workflows/test.yml

@@ -125,11 +125,11 @@ jobs:
 
       - name: Build
         run:  |
-          /bin/bash mfc.sh test --dry-run -j $(nproc) --${{ matrix.debug }} --${{ matrix.mpi }} --${{ matrix.precision }} 
+          /bin/bash mfc.sh test -v --dry-run -j $(nproc) --${{ matrix.debug }} --${{ matrix.mpi }} --${{ matrix.precision }}
 
       - name: Test
         run:  |
-          /bin/bash mfc.sh test --max-attempts 3 -j $(nproc) $OPT1 $OPT2
+          /bin/bash mfc.sh test -v --max-attempts 3 -j $(nproc) $OPT1 $OPT2
         env:
           OPT1: ${{ matrix.mpi == 'mpi' && '--test-all' || '' }}
           OPT2: ${{ matrix.debug == 'debug' && '-% 20' || '' }}

mfc.sh

@@ -16,32 +16,8 @@ if [ -d "$(pwd)/.git" ] && [ ! -e "$(pwd)/.git/hooks/pre-commit" ] && [ -f "$(pw
     log "Installed git pre-commit hook (runs$MAGENTA ./mfc.sh precheck$COLOR_RESET before commits)."
 fi
 
-# Auto-install shell completions (once)
-COMPLETION_DIR="$HOME/.local/share/mfc/completions"
-if [ ! -d "$COMPLETION_DIR" ]; then
-    mkdir -p "$COMPLETION_DIR"
-    cp "$(pwd)/toolchain/completions/mfc.bash" "$COMPLETION_DIR/"
-    cp "$(pwd)/toolchain/completions/_mfc" "$COMPLETION_DIR/"
-
-    # Add to shell rc file based on current shell
-    if [[ "$SHELL" == *"zsh"* ]]; then
-        RC_FILE="$HOME/.zshrc"
-        RC_LINE="fpath=(\"$COMPLETION_DIR\" \$fpath)"
-        SOURCE_CMD="source $COMPLETION_DIR/_mfc"
-    else
-        RC_FILE="$HOME/.bashrc"
-        RC_LINE="[ -f \"$COMPLETION_DIR/mfc.bash\" ] && source \"$COMPLETION_DIR/mfc.bash\""
-        SOURCE_CMD="source $COMPLETION_DIR/mfc.bash"
-    fi
-
-    if [ -f "$RC_FILE" ] && ! grep -q "$COMPLETION_DIR" "$RC_FILE" 2>/dev/null; then
-        echo "" >> "$RC_FILE"
-        echo "# MFC shell completion" >> "$RC_FILE"
-        echo "$RC_LINE" >> "$RC_FILE"
-    fi
-
-    log "Installed tab completions. Restart shell or run:$MAGENTA $SOURCE_CMD$COLOR_RESET"
-fi
+# Shell completions auto-install/update
+. "$(pwd)/toolchain/bootstrap/completions.sh" "$(pwd)"
 
 # Print startup message immediately for user feedback
 log "Starting..."
@@ -72,33 +48,33 @@ if [ "$1" '==' 'load' ] && [ "$2" != "--help" ] && [ "$2" != "-h" ]; then
         echo ""
         exit 1
     fi
-    shift; . "$(pwd)/toolchain/bootstrap/modules.sh" $@; return
+    shift; . "$(pwd)/toolchain/bootstrap/modules.sh" "$@"; return
 elif [ "$1" '==' "lint" ] && [ "$2" != "--help" ] && [ "$2" != "-h" ]; then
-    . "$(pwd)/toolchain/bootstrap/python.sh"
+    . "$(pwd)/toolchain/bootstrap/python.sh" "$@"
 
-    shift; . "$(pwd)/toolchain/bootstrap/lint.sh"    $@; exit 0
+    shift; . "$(pwd)/toolchain/bootstrap/lint.sh" "$@"; exit 0
 elif [ "$1" '==' "format" ] && [ "$2" != "--help" ] && [ "$2" != "-h" ]; then
-    . "$(pwd)/toolchain/bootstrap/python.sh"
+    . "$(pwd)/toolchain/bootstrap/python.sh" "$@"
 
-    shift; . "$(pwd)/toolchain/bootstrap/format.sh"  $@; exit 0
+    shift; . "$(pwd)/toolchain/bootstrap/format.sh" "$@"; exit 0
 elif [ "$1" '==' "venv" ]; then
-    shift; . "$(pwd)/toolchain/bootstrap/python.sh"  $@; return
+    shift; . "$(pwd)/toolchain/bootstrap/python.sh" "$@"; return
 elif [ "$1" '==' "clean" ] && [ "$2" != "--help" ] && [ "$2" != "-h" ]; then
     rm -rf "$(pwd)/build"; exit 0
 elif [ "$1" '==' "spelling" ] && [ "$2" != "--help" ] && [ "$2" != "-h" ]; then
-    . "$(pwd)/toolchain/bootstrap/python.sh"
+    . "$(pwd)/toolchain/bootstrap/python.sh" "$@"
 
-    shift; . "$(pwd)/toolchain/bootstrap/spelling.sh" $@; exit 0
+    shift; . "$(pwd)/toolchain/bootstrap/spelling.sh" "$@"; exit 0
 elif [ "$1" '==' "precheck" ]; then
-    . "$(pwd)/toolchain/bootstrap/python.sh"
+    . "$(pwd)/toolchain/bootstrap/python.sh" "$@"
 
-    shift; . "$(pwd)/toolchain/bootstrap/precheck.sh" $@; exit 0
+    shift; . "$(pwd)/toolchain/bootstrap/precheck.sh" "$@"; exit 0
 fi
 
 mkdir -p "$(pwd)/build"
 
 . "$(pwd)/toolchain/bootstrap/cmake.sh"
-. "$(pwd)/toolchain/bootstrap/python.sh"
+. "$(pwd)/toolchain/bootstrap/python.sh" "$@"
 
 # init command: just bootstrap the environment and exit (no Python command)
 if [ "$1" '==' 'init' ]; then
@@ -108,7 +84,16 @@ fi
 echo
 
 # Run the main.py bootstrap script
-python3 "$(pwd)/toolchain/main.py" "$@"
+# If only flags given (no command), show help without passing flags
+has_command=false
+for arg in "$@"; do
+    case "$arg" in -*) ;; *) has_command=true; break ;; esac
+done
+if [ "$has_command" = true ]; then
+    python3 "$(pwd)/toolchain/main.py" "$@"
+else
+    python3 "$(pwd)/toolchain/main.py"
+fi
 code=$?
 
 echo