Skip to content

Fix silent viscosity loss on AMD flang GPU (host-capture Re_size in the Riemann solvers) - #1588

Merged
sbryngelson merged 4 commits into
masterfrom
fix-amdflang-re-size-allocatable
Jun 15, 2026
Merged

Fix silent viscosity loss on AMD flang GPU (host-capture Re_size in the Riemann solvers)#1588
sbryngelson merged 4 commits into
masterfrom
fix-amdflang-re-size-allocatable

simulation: firstprivate Re_size as two scalars, not an array (AMD-fl…

da4b6e3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 15, 2026 in 0s

60.94% (target 1.00%)

View this Pull Request on Codecov

60.94% (target 1.00%)

Details

Codecov Report

❌ Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.94%. Comparing base (ac5774e) to head (da4b6e3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_riemann_solver_hllc.fpp 50.00% 3 Missing and 2 partials ⚠️
src/simulation/m_riemann_solver_lf.fpp 42.85% 0 Missing and 4 partials ⚠️
src/simulation/m_riemann_solver_hll.fpp 25.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1588   +/-   ##
=======================================
  Coverage   60.94%   60.94%           
=======================================
  Files          82       82           
  Lines       19922    19925    +3     
  Branches     2924     2924           
=======================================
+ Hits        12141    12144    +3     
  Misses       5805     5805           
  Partials     1976     1976

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov