Skip to content

Stop NVHPC IPO silently miscompiling the six-equation relaxation kernel #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 3 commits into from
Sep 14, 2026
+15 −5
Merged

Stop NVHPC IPO silently miscompiling the six-equation relaxation kernel #1878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f5ab35
fix: stop NVHPC IPO silently miscompiling the six-equation relaxation…
sbryngelson Sep 13, 2026
e9a3d79
Fix typo in module m_cbc brief comment
sbryngelson Sep 13, 2026
4cd1947
style: wrap the m_cbc brief comment the typo fix pushed over the limit
sbryngelson Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions cmake/MFCTargets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,20 @@ exit 0
add_dependencies(${ARGS_TARGET} ${ARGS_TARGET}_lib)
target_compile_options(${ARGS_TARGET} PRIVATE -Minline=lib:${ARGS_TARGET}_lib,except:f_is_default,except:s_compute_dt,except:my_inquire,except:s_mpi_abort,except:s_mpi_barrier,except:s_prohibit_abort,except:s_int_to_str,except:s_associate_cbc_coefficients_pointers)

# Exclude m_start_up and m_cbc from cross-file inlining: these are
# initialization/boundary code that trigger NVHPC 25.x fort2 ICE when
# too many functions are cross-inlined into them. GPU hot-path files
# Exclude these files from cross-file inlining. GPU hot-path files
# (m_rhs, m_riemann_solvers, m_viscous, m_weno, etc.) keep full IPO.
foreach(_no_inline_file m_start_up m_cbc)
#
# m_start_up, m_cbc initialization/boundary code that trigger
# NVHPC 25.x fort2 ICEs when too many functions
# are cross-inlined into them.
# m_pressure_relaxation worse than an ICE, because it compiles: inlining
# the equation-of-state chain (s_phase_coefficients
# -> s_eos_coefficients -> s_reference_curve,
# s_phase_internal_energy, f_pressure) into the
# six-equation relaxation kernel silently drops the
# internal-energy update, leaving alpha and
# alpha_rho correct and int_en zero.
foreach(_no_inline_file m_start_up m_cbc m_pressure_relaxation)
set_source_files_properties(
"${CMAKE_BINARY_DIR}/fypp/${ARGS_TARGET}/${_no_inline_file}.fpp.f90"
TARGET_DIRECTORY ${ARGS_TARGET}
Expand Down
3 changes: 2 additions & 1 deletion src/simulation/m_cbc.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
!! @file
!! @brief Contains module m_cbc

!> @brief Characteristic boundary conditions (CBC) for slip walls, non-reflecting subsonic inflow/outflow, and supersonic boundaries
!> @brief Characteristic boundary conditions (CBCs) for slip walls, non-reflecting subsonic inflow/outflow, and supersonic
!! boundaries
#:include 'case.fpp'
#:include 'macros.fpp'

Expand Down
Loading