feat(build): report which commit this process was actually loaded from - #4
Merged
Conversation
bb bundles a `path:` plugin FROM SOURCE at reload, so a revision read at module load is by construction the code now executing. Nothing else on the machine can answer it: `bb plugin list` prints `running` and the source path but no revision, `bb plugin source` has none to record for a path: source, and dist/ is not the loaded artifact — its mtime was measured lying by fifteen minutes. Answered FIRST in run(), ahead of `provision` (which creates tunnel, DNS and Access) and `share` (which EXPOSES a local port to the internet). "What is running" must stay answerable when the thing running is broken, and must never have a side effect of its own. Eighth plugin on the pattern proved in MX-139; setup/verify/84-bb.sh in dotfiles picks it up with no change there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MX-141. Eighth plugin on the pattern proved in MX-139 (
bb-plugin-accounts).bb bundles a
path:plugin from source at reload, so a revision read at module load is by construction the code now executing. Nothing else can say:bb plugin listprintsrunningand the source path but no revision,bb plugin sourcehas none to record for apath:source, anddist/is not the loaded artifact — its mtime was measured lying by 15 minutes.Answered first in
run(), ahead ofprovision(creates tunnel, DNS and Access) andshare(exposes a local port to the internet). "What is running" must stay answerable when the thing running is broken, and must never have a side effect of its own.dirtyrides along because a bundle built from an edited tree matches no commit; a missing git dir yieldsrev: nullrather than a guess.Verified
npm test— 77 passing, 0 failing.node --checkclean.One pre-existing thing worth flagging, not caused by this change
npm run typecheckrunstsc --noEmit, but this repo has notsconfig.json, so tsc just prints its help text and exits 0. The script has therefore never typechecked anything, and its exit code makes it look like it did. Not fixing it here — that is a separate call — but it should not keep passing silently.🤖 Generated with Claude Code