Allow to disable the automatic rdb snapshot in valkey#403
Merged
ostefano merged 2 commits intoMISP:masterfrom Mar 31, 2026
Merged
Allow to disable the automatic rdb snapshot in valkey#403ostefano merged 2 commits intoMISP:masterfrom
ostefano merged 2 commits intoMISP:masterfrom
Conversation
By default, Valkey dumps regularly a snapshot, on testing/demo environnment, we may want to avoid the extra fs pressure
ostefano
requested changes
Mar 26, 2026
Collaborator
ostefano
left a comment
ostefano
left a comment
There was a problem hiding this comment.
Should it be "DISABLE" since this is soemthing that should always be enabled bar additional cases?
Contributor
Author
|
Yes, but I find less confusing to read something |
Collaborator
|
My point is that if you provide an option called ENABLE_X, I would expect X to be disabled by default. |
Contributor
Author
|
I've renamed the option. |
ostefano
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, Valkey dumps regularly a snapshot, on testing/demo environnment, we may want to avoid the extra fs pressure