Refresh the MISP website visual design - #138
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d5e36a2d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {{ $hasSections := (hasPrefix (index .Children 0).Identifier "section.") }} | ||
| <li class="dropdown{{ if $hasSections }} use-yamm yamm-fw{{end}} {{ $active }}"> | ||
| <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false">{{ .Name }} <span class="caret"></span></a> | ||
| <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"{{ if $active }} aria-current="page"{{ end }}>{{ .Name }} <span class="caret"></span></a> |
There was a problem hiding this comment.
When a parent menu URL is the current page—for example, /events/—this adds aria-current="page" to the dropdown control whose href is only #. Screen-reader users are therefore told that a non-navigating toggle represents the current page, while the actual /events/ link in the submenu has no current-page indication. Apply aria-current to the matching submenu destination instead.
Useful? React with 👍 / 👎.
1 participant
Motivation
Description
static/css/custom.csswith a new cohesive visual system using CSS custom properties for colors, radii, shadows, typography, spacing and component styles, and updated rules for the hero, cards, CTAs, forms, blog and footer.layouts/partials/nav.htmlto add mobile-menu ARIA attributes (aria-controls,aria-expanded) and mark active links witharia-current="page"for better accessibility.prefers-reduced-motionhandling to limit motion for users who prefer it.Testing
git diff --checkto validate the working tree for whitespace and trivial diffs which completed successfully.git submodule update --init --recursive && hugo versionbut the build could not run due to the environment blocking submodule fetch and the absence of a localhugobinary, so a render preview/screenshot was not produced.Codex Task