Refresh MISP features experience: feature catalogue, layout and styles - #142
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 142591444b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - id: sharing | ||
| title: Share & collaborate | ||
| icon: fas fa-people-arrows |
There was a problem hiding this comment.
The site loads Font Awesome 5.11.2 in layouts/partials/headers.html, but fa-people-arrows was introduced in a later release. Consequently, the Share & collaborate icon is blank in both the category navigation and section header; use an icon included in 5.11.2 or update the loaded Font Awesome version.
Useful? React with 👍 / 👎.
| {{ range $group.features }} | ||
| <article class="feature-card"> | ||
| <i class="fas fa-check" aria-hidden="true"></i> | ||
| <div><h3>{{ .title }}</h3><p>{{ .description }}</p>{{ with .link }}<a href="{{ . }}">Learn more <span aria-hidden="true">→</span></a>{{ end }}</div> |
There was a problem hiding this comment.
The new template emits data-provided links verbatim, so the internal /openapi/ entry navigates to the domain root rather than the configured Hugo base path. In the GitHub Pages workflow, where --baseURL comes from configure-pages and can include a repository subpath, this card therefore leads outside the generated site while the other internal links correctly use relURL; apply relURL to internal entries while leaving external URLs unchanged.
Useful? React with 👍 / 👎.
| .features-eyebrow { | ||
| color: #47cee0; | ||
| display: block; | ||
| font-size: 13px; |
There was a problem hiding this comment.
The shared eyebrow color #47cee0 has only about a 1.8:1 contrast ratio against the white background used by .features-intro. Because this is 13px text, the “A complete intelligence lifecycle” label falls well below the WCAG 4.5:1 requirement and is difficult to read for low-vision users; give the light-background variant a darker color while retaining the cyan on dark sections.
Useful? React with 👍 / 👎.
1 participant
Motivation
/features/experience to be more attractive and scannable while aligning the listed capabilities with the MISP 2.5 feature set.Description
content/features.mdto use a purpose-builtfeatureslayout and keep the legacy/features.htmlalias via front matter (content/features.md).data/feature_catalog.yamlcontaining six categories and 29 concise feature entries representing MISP 2.5 capabilities for use by the template (data/feature_catalog.yaml).layouts/page/features.html.static/css/custom.css.Testing
ruby -e 'require "yaml"; d=YAML.load_file("data/feature_catalog.yaml"); abort unless d.length==6 && d.sum{|g| g["features"].length}==29'which succeeded.{{and}}inlayouts/page/features.htmland the counts matched.git diff --checkand repository lint checks (rg/diff checks) and found no errors.hugo --minifybut thehugobinary is not available in this environment, so a rendered build and screenshots were not produced.Codex Task