Redesign homepage banner to feature MISP 2.5.47 and improve carousel visuals - #144
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
layouts/partials/carousel.htmlthat renders a product-focused hero fromdata/carousel/*entries with an accessible structure, eyebrow, title, description, primary/secondary CTAs, image alt text and optional caption.data/carousel/threat_sharing.yaml,visualization.yaml,galaxy.yamlandart.yamlto includeeyebrow, refinedtitleanddescriptioncopy,imagereferences,image_alt,image_caption,url, and button label fields to be release- and feature-specific.static/css/custom.csswith a responsive two-column hero layout, a browser-style screenshot frame, eyebrow styling, improved CTA appearance, mobile layout overrides and accessible sizing rules.Site.Params.carouselHomepage.enableparameter.Testing
ruby -e 'require "yaml"; Dir["data/carousel/*.yaml"].each { |f| d=YAML.safe_load_file(f); abort("missing #{d["image"]}") unless File.file?("static/#{d["image"]}"); puts "#{f}: valid" }'which reported all carousel YAML files as valid and images present.git diff --checkwhich reported no whitespace or basic diff issues, and verifiedcontent/blog/MISP.2.5.47.released.mdexists for the release link.hugo --minifybut the environment lackedhugoand the theme submodule could not be fetched due to a network/proxy restriction, so a rendered build could not be produced.403and missing browser automation tooling, so no rendered screenshot capture was produced in this environment.Codex Task