Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Issue #6 comes from the bug that statement
os.path.exists(complete_path_logs_current_training_job)always beTrue.When we start a new training job, this code
PD-MeshNet/pd_mesh_net/utils/base_training_job.py
Line 202 in e3f6c01
will generate folder
$PD_MESH_NET_ROOT/training_logs/new_job/checkpoints. It means that folder$PD_MESH_NET_ROOT/training_logs/new_jobhas been already created.Then,
PD-MeshNet/pd_mesh_net/utils/base_training_job.py
Line 217 in e3f6c01
complete_path_logs_current_training_jobis defined as$PD_MESH_NET_ROOT/training_logs/new_job, which is created before this definition. So the statementos.path.exists(complete_path_logs_current_training_job)will always beTrueand the program will try to load previous checkpoint although we launch a new training job.Changes
To fix it, just move the checkpoint creation codes after the
if (not os.path.exists(complete_path_logs_current_training_job))statement.