Repository navigation
feat: EnumValidator for sound, effect, and particle validation - #1
MLG-SERBUR wants to merge 9 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85de025d68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex validate if these are all correct. pull spigot and paper javadocs as needed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85de025d68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex |
|
To use Codex here, create an environment for this repo. |
|
@codex [16:31:36] [Server thread/WARN]: [RotatoR] Task #35 for RotatoR v1.0.7P generated an exception java.lang.IllegalArgumentException: No enum constant org.bukkit.Effect.SMOKE at java.base/java.lang.Enum.valueOf(Enum.java:293) ~[?:?] at org.bukkit.Effect.valueOf(Effect.java:16) ~[purpur-api-26.2.build.2622-stable.jar:?] at RotatoR.jar//net.awesomepowered.rotator.types.BlockSpinner.play(BlockSpinner.java:163) ~[?:?] at RotatoR.jar//net.awesomepowered.rotator.types.BlockSpinner.lambda$spoolUp$0(BlockSpinner.java:133) ~[?:?] at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:78) ~[purpur-26.2.jar:26.2-2622-48bcd91] at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:474) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1803) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1656) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:450) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.MinecraftServer.processPacketsAndTick(MinecraftServer.java:1714) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1384) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:303) ~[purpur-26.2.jar:26.2-2622-48bcd91] at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?] [16:31:36] [Server thread/INFO]: [MountainDewritoes] Logged exception from plugin RotatoR to: plugins/MountainDewritoes/RotatoR_exceptions.log [16:31:36] [Server thread/WARN]: [RotatoR] Task #50 for RotatoR v1.0.7P generated an exception java.lang.IllegalArgumentException: No enum constant org.bukkit.Effect.VILLAGER_PLANT_GROW at java.base/java.lang.Enum.valueOf(Enum.java:293) ~[?:?] at org.bukkit.Effect.valueOf(Effect.java:16) ~[purpur-api-26.2.build.2622-stable.jar:?] at RotatoR.jar//net.awesomepowered.rotator.types.BlockSpinner.play(BlockSpinner.java:163) ~[?:?] at RotatoR.jar//net.awesomepowered.rotator.types.BlockSpinner.lambda$spoolUp$0(BlockSpinner.java:133) ~[?:?] at org.bukkit.craftbukkit.scheduler.CraftTask.run(CraftTask.java:78) ~[purpur-26.2.jar:26.2-2622-48bcd91] at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:474) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1803) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1656) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.dedicated.DedicatedServer.tickServer(DedicatedServer.java:450) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.MinecraftServer.processPacketsAndTick(MinecraftServer.java:1714) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1384) ~[purpur-26.2.jar:26.2-2622-48bcd91] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:303) ~[purpur-26.2.jar:26.2-2622-48bcd91] at java.base/java.lang.Thread.run(Thread.java:1474) ~[?:?] |
|
Summary
Testing
|
d2675b5 to
a67a5ed
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
… not using utf-8 encoding
2 participants
Adds load-time validation and auto-conversion of
Sound/Effect/Particleconfig values via newEnumValidatorclass.RECORD_/NOTE_, 1.13-PARTICLE_flattening, 1.19.3-BLOCK_NOTE_, 1.21.x Effect renames likeSMOKE→SMOKE_SHOOT) at load timeSoundbeing an interface on 1.21.3+ (field lookup +valueOffallback)setEffectinstead ofsetParticle)Built on
upstream/master(0fa8d62).