Timing improvements and fixes#55
Merged
Exterminate5573 merged 15 commits intoMPKMod:masterfrom Mar 18, 2026
Merged
Conversation
- Enforce bounds order in the constructor - Rename isAbove method to isValueAbove - Create isValueBelow method - Add equals method
… annotation above Component
These new classes aim to replace one of the current two responsibilities of TimingInput: it can represent both actual player input and a theoretical input predicate. The next commit fixes this by making it only an actual input model.
This tightens TimingInput's responsibility, which used to also be used for input predicates. The latter are now represented using the new InputPredicate* classes.
Exterminate5573
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timing definition format and the programmatic model were improved in order to fix the following issues:
Key changes
TimingInputwas split in two:InputPredicateserves as the theoretical input predicate representationTimingInputnow only represents concrete player inputInputPredicateis more flexible and lets you define which keys are required, forbidden and optionalInputPredicateReferencelets you reference a pastInputPredicateto match the same inputs across timing entries