core: 他ドメインから設定を読む口を追加(Pro専用機能の下ごしらえ) - #101
Merged
Merged
Conversation
既存のdownloads.csv記録の仕組みに、GitHub Traffic API(views/clones)を 同じ安全策(失敗したらCSVに触らない)で追記するステップを追加。 MrkAppReleaseのcollect-metrics.shと同様、Administration:read権限が 要るためTRAFFIC_TOKENを優先しGITHUB_TOKENへフォールバックする。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
AppSettings/EditorTheme/EditorFontの各getterを「自ドメイン向けcomputed var」と 「任意のUserDefaultsから読む関数」に分離し、FreeSettingsImportから同じ復号ロジックを 再利用できるようにした。無料版のメニュー・実行ファイルはFreeSettingsImportを一切 参照しないため、Pro専用の機能でありながらPro.allows()のゲートは不要(check_consistency.py のpro_gate検査でも確認済み)。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppSettings/EditorTheme/EditorFontの各getterを、自ドメイン向けと「任意のUserDefaultsから読む」関数に分離FreeSettingsImport(public)を追加。無料版の設定ドメインから外観+一部の挙動設定を読み、確認のうえ適用するための下ごしらえPro.allows()のゲート対象外(check_consistency.pyのpro_gate検査で確認済み)Test plan
swift build/swift test(886件パス)python3 scripts/check_consistency.py(pro_gate含め全項目OK、downstream_build=MrkEditorのビルドも確認済み)🤖 Generated with Claude Code