fix sanitizer to replace control characters with a question mark#403
Open
nschimme wants to merge 1 commit intoMUME:masterfrom
Open
fix sanitizer to replace control characters with a question mark#403nschimme wants to merge 1 commit intoMUME:masterfrom
nschimme wants to merge 1 commit intoMUME:masterfrom
Conversation
This fixes corrupted user maps with a "River Lh\x00n" room name.
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider adding tests for other control characters (e.g., BEL, DEL) to ensure they are consistently replaced with '?'.
- Extract the control-character check and replacement logic in BasicCharsetInserter into a small helper function to improve readability and maintainability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding tests for other control characters (e.g., BEL, DEL) to ensure they are consistently replaced with '?'.
- Extract the control-character check and replacement logic in BasicCharsetInserter into a small helper function to improve readability and maintainability.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes corrupted user maps with a "River Lh\x00n" room name.
Summary by Sourcery
Map ASCII control characters including NUL to the default unmapped character ('?') during sanitization and charset insertion.
Bug Fixes:
Tests: