Skip archived diamond IO CSV rows in benchmark log checks#132
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea53a33cdb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
|
|
||
| def is_archived(row: dict[str, str]) -> bool: | ||
| return row.get("archived", "").strip().lower() in {"1", "true", "yes", "y"} |
There was a problem hiding this comment.
Treat missing archived cells as active rows
When a CSV adds an archived column but older/active rows omit the trailing field, csv.DictReader supplies None for that cell, so this .strip() raises AttributeError before any rows are checked. That makes the new archived-row support fragile for partially backfilled CSVs; coerce the value with something like (row.get("archived") or "") so omitted flags remain active rows.
Useful? React with 👍 / 👎.
Summary
1,true,yes, andy.Testing