Skip to content

Skip archived diamond IO CSV rows in benchmark log checks#132

Merged
SoraSuegami merged 1 commit into
mainfrom
codex/aky24-input80-bench-rerun
Jun 19, 2026
Merged

Skip archived diamond IO CSV rows in benchmark log checks#132
SoraSuegami merged 1 commit into
mainfrom
codex/aky24-input80-bench-rerun

Conversation

@SoraSuegami

Copy link
Copy Markdown
Member

Summary

  • Ignore archived rows when reading diamond IO benchmark CSV logs.
  • Add a small helper to normalize archived flags such as 1, true, yes, and y.
  • Keep checksum and value matching focused on active benchmark entries only.

Testing

  • Not run (not requested)

@SoraSuegami
SoraSuegami merged commit c4458b4 into main Jun 19, 2026
2 checks passed
@SoraSuegami
SoraSuegami deleted the codex/aky24-input80-bench-rerun branch June 19, 2026 20:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea53a33cdb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".



def is_archived(row: dict[str, str]) -> bool:
return row.get("archived", "").strip().lower() in {"1", "true", "yes", "y"}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Treat missing archived cells as active rows

When a CSV adds an archived column but older/active rows omit the trailing field, csv.DictReader supplies None for that cell, so this .strip() raises AttributeError before any rows are checked. That makes the new archived-row support fragile for partially backfilled CSVs; coerce the value with something like (row.get("archived") or "") so omitted flags remain active rows.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant