Fix benchmarks for ring-gsw over BGG+ encodings#135
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82db0424cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if bench_dir.exists() { | ||
| fs::remove_dir_all(&bench_dir).expect("failed to clear DiamondWE encoding bench directory"); | ||
| } | ||
| ensure_dir(&bench_dir); |
There was a problem hiding this comment.
When this helper runs, the global LUT writer is still initialized to final_dir from the caller, so write_dummy_aux_for_poly_encode_bench writes the batch files there while wait_for_all_writes(bench_dir) writes the index under final_dir/encoding_bench; the following LWEBGGEncodingPltEvaluator then reads from bench_dir and cannot find the referenced batch files. Initialize the storage system with bench_dir.clone() before enqueueing these dummy aux writes, as the other new encoding benchmark helpers do.
Useful? React with 👍 / 👎.
SoraSuegami
changed the title
1 participant
No description provided.