fix: rebase target qty on unfilled position top-ups#1
Open
Magic-Jia wants to merge 422 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
python scripts/verify.py --changed trading_system/app/portfolio/positions.py --changed trading_system/tests/test_target_management_state.py1089 passed in 2.86sgit diff --check HEADcleanpython scripts/verify.py --suite full6733 passed in 185.90sgit diff --check HEADcleanPaper evidence
4h proof bundle:
/tmp/s-tier-four-hour-performance-proof-retry-I8jwk1/output/summary.json/tmp/s-tier-four-hour-performance-proof-retry-I8jwk1/runtime/paper/microstructure-four-hour-performance-proof-retry/execution_log.jsonl/tmp/s-tier-four-hour-performance-proof-retry-I8jwk1/runtime/paper/microstructure-four-hour-performance-proof-retry/paper_ledger.jsonlObserved results:
Promotion status
This is not promoted yet. The current decision is
observe, because there are no active recommendations to validate and the latest funnel is risk-off / blocked. This patch closes the top-up target quantity correctness gap and makes the paper evidence loop observable, but longer paper/live-sim evidence is still required before promotion.