Effect switchable when JEI is not installed. - #232
Open
Zershyan wants to merge 1 commit into
Open
Conversation
Collaborator
|
do you know, parameters before CallbackInfo is not necessary |
Author
我知道这个，只是编译器没有标灰色我就没管（ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be precise, now you can toggle the effect even when there's no effect tooltip.
When JEI is installed, the effect will render as a square, and then they have tooltips.
But when JEI isn't installed, there won't be any tooltips, so the switch feature can't be used.
准确的说，现在可以在没有药水效果tooltip的时候开关它了
装了JEI之后，药水效果会被jei挤的只渲染一个正方形，这时候就会有tooltip，才可以开关它
但是当没有安装JEI，药水效果会以条状长方形渲染，是没有tooltip的，开关不了它
pr修复了这个问题