fix(openai): preserve reasoning_content for DeepSeek thinking mode#39
Open
icn5381 wants to merge 1 commit intoMagicCube:mainfrom
Open
fix(openai): preserve reasoning_content for DeepSeek thinking mode#39icn5381 wants to merge 1 commit intoMagicCube:mainfrom
icn5381 wants to merge 1 commit intoMagicCube:mainfrom
Conversation
DeepSeek (and other thinking-mode providers) require reasoning_content to be passed back in subsequent API calls. Previously, ThinkingContent was explicitly skipped during message conversion, causing a 400 error on the second turn of any conversation using thinking mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoning_contentto be passed back in conversation history, butconvertToOpenAIMessages()was explicitly skippingThinkingContentwithcontinueThe reasoning_content in the thinking mode must be passed back to the APIThinkingContentback toreasoning_contenton the assistant message paramtop_pdefault fix (0 → 1) for DeepSeek compatibilityTest plan
convertToOpenAIMessagescovering thinking content preservationbun run checkpasses (types, lint, 68 tests)