Add toggle to hide the status bar mute icon on Android 17 QPR1+ - #961
Open
mbahakeskin wants to merge 1 commit into
Open
mbahakeskin wants to merge 1 commit into
mbahakeskin wants to merge 1 commit into
Conversation
Owner
|
Thanks for the PR. I think we should gate this setting behind an Android 17 check so that it isn't shown to Android 16 users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android 17 QPR1 moved status bar icon rendering to a new Compose-based pipeline (behind the
status_bar_root_modernizationandstatus_bar_system_status_icons_in_composeaconfig flags, both enabled and read-only on release builds). The oldicon_blacklistSecure setting that StatusbarMisc previously relied on for hiding things like the mute icon is no longer read by this new pipeline.I found that the new code (
HomeStatusBarIconBlockListInteractor) reads a separate, dedicated Secure setting for the mute icon:status_bar_show_mute_icon(0 hides it, default is shown). SystemUI observes this reactively, so writing it takes effect immediately, no restart needed.This adds a "Hide Mute Icon" switch under Statusbar > Icon Visibility. It writes
status_bar_show_mute_iconfrom inside the SystemUI hook (mContextthere is SystemUI's own context, which already holdsWRITE_SECURE_SETTINGS), the same approachStatusbarMiscalready uses for the lockscreen carrier/statusbar hiding.I don't see an equivalent setting for Bluetooth yet on QPR1. QPR2 Beta 4 adds a new
BluetoothIconViewModel, but its visibility is computed purely from Bluetooth connection state, no settings-backed toggle. Might be worth revisiting once that lands in a stable release.Compiled clean (
compileFossDebugKotlin), but I don't have an LSPosed test rig handy, so this hasn't been verified on-device. Happy to adjust if something's off.