Repository navigation
Pairing follow-ups: new key over a kept one, no Hub Wi-Fi, cage guard - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For review, do not merge yet.
api_encryptionwhile the Hub still holds a key it gave it earlier (soft-unpaired, then reflashed with its own YAML key) is now offered with[none, secret]instead of[none], so the user can enter the new key.nonestill pairs with the kept key.wifi_credentials()returningNone(or an SDK without it) makespair_deviceof a BLE discovery raise the SDK'sMissingCredentialsErrorwith typewifibefore any BLE step. The discovery'slast_erroris left alone: the Hub returns the error to the app's pairing request as a 422 with the keptdevice_idandcredentials_type: "wifi"(ParkerIndustries/MajorDom-Hub#149), and the app retries on that id after the user saves Wi-Fi on the Hub.wifiis the only type this integration raises.tests/hardwarechanges (cage DUT guard) are reverted here and move to the Hub repo.Merge order
Depends on
MissingCredentialsErrorfrom integration-sdk#6, not in any SDK release yet; CI here fails on import until then.majordom-integration-sdkhere to that release (pyproject.toml+poetry.lock), and in MajorDom-Hub#149.Tests
Tests-first: the Hub-Wi-Fi tests now assert
last_errorstaysNoneand failed (2 failed) before the controller change. With the SDK branchfeature/credentials-optioninstalled in the venv:pytest tests138 passed on Python 3.13,ruff check,ruff formatandty checkclean. The hardware test was not run (no cage access).