Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Autoresearch plugin’s documentation and protocols to close a trust boundary in --resume: executable commands (Verify:/Guard:) must come from the current invocation and must never be restored from autoresearch-state.json, preventing command injection from tampered state files.
Changes:
- Document that
verify_cmd/guard_cmdinautoresearch-state.jsonare record-only metadata and must not be executed on resume. - Update the resume protocol to restore only non-executable loop state and require
Verify:to be provided again when resuming. - Add explicit trust-boundary guidance to the autonomous loop protocol and skill invariants.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/autoresearch/skills/autoresearch/SKILL.md | Adds a safety invariant stating commands from state must not be trusted on --resume. |
| plugins/autoresearch/skills/autoresearch/references/state-management.md | Clarifies schema semantics for verify_cmd/guard_cmd and updates resume steps to avoid executing commands from disk. |
| plugins/autoresearch/skills/autoresearch/references/autonomous-loop-protocol.md | Adds a trust-boundary step to the Verify phase to prevent command execution from resumed state. |
| plugins/autoresearch/commands/autoresearch.md | Updates --resume docs and resume execution steps to require Verify: on resume and ignore state-file command fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/autoresearch/skills/autoresearch/references/state-management.md
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
verify_cmdandguard_cmdfromautoresearch-state.jsonand would execute them, allowing an attacker-controlled state file to inject arbitrary shell commands when--resumeis used.Description
Verify:(and optionallyGuard:) to be provided by the user when resuming and ignoreverify_cmd/guard_cmdvalues loaded fromautoresearch-state.jsonso executable commands from disk are never executed.verify_cmdandguard_cmdin the state schema as record-only metadata and add explicit resume protocol steps that restore only non-executable loop state.plugins/autoresearch/commands/autoresearch.md,plugins/autoresearch/skills/autoresearch/references/state-management.md,plugins/autoresearch/skills/autoresearch/references/autonomous-loop-protocol.md, andplugins/autoresearch/skills/autoresearch/SKILL.md.Testing
Codex Task