Repository navigation
Controller Studio V.2026.2 — integrated library and Plugin Studio - #12
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3804d63392
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if len(slots) > len(best): | ||
| best = slots |
There was a problem hiding this comment.
Select the active controller map when capturing names
When a project contains multiple hardware controllers with different presets for the same plug-in type, this loop returns whichever controller has the most mapped slots, regardless of which Controller Map is active in LiveProfessor. The OSC labels come from the active map, so applying them through another controller's slot layout can assign names to the wrong parameter IDs; derive the slots from the active map/controller rather than selecting by mapping size.
Useful? React with 👍 / 👎.
| "id": "encoder_17", | ||
| "kind": "absolute_encoder", | ||
| "input": { | ||
| "message": "cc", | ||
| "channel": 1, | ||
| "number": 16 |
There was a problem hiding this comment.
Model the Twister banks without unreachable controls
With bank_size: 16 and bank_count: 4, ControllerProfile.controls_for_bank() returns self.controls[:16] for every bank, so the newly declared encoder_17 through encoder_64 entries are never exposed by bank-aware consumers. For example, MappingPlanner maps bank 2 using encoder_01 and CC 0 rather than this entry and CC 16, and repeats that error for all later banks; the profile must use the model's physical-control banking semantics or the model must slice the bank-specific control ranges.
Useful? React with 👍 / 👎.
Résumé
Validation
.rack2publié.