Repository navigation
Explain the AutoMap advantage in the README - #16
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b8ffc21b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | Labels and feedback | Depend on the mappings built by hand | Short names, values and Companion feedback follow the same order as the controls | | ||
| | Project safety | Mapping is performed inside the open project | AutoMap creates and validates a new `.rack2` copy; the source project remains untouched | | ||
|
|
||
| Existing manual mappings are never overwritten: they remain authoritative and AutoMap fills only the available slots. The result is a reusable system that maintains one controller bank and one plug-in bank instead of many **controller × plug-in × instance** mappings. |
There was a problem hiding this comment.
Qualify the manual-mapping preservation promise
When a user selects only some plug-in instances and the active or snapshot-recalled runtime map contains a MIDI-learned rotary assignment for an unchecked instance, this promise is false: _runtime_map_context removes every rotary assignment owned by the selected controller, while combined_assignments rebuilds mappings only for selected_plugins, so the unchecked instance's manual assignment disappears from the generated copy. The mirrored English statement should explain this limitation rather than assuring users that manual mappings are never overwritten and only free slots are filled.
Useful? React with 👍 / 👎.
What changed
Why
The existing README listed AutoMap as a feature but did not explain its main benefit: avoiding a separate controller × plug-in × instance mapping for every combination.
Validation
git diff --checkpasses