Skip to content

Add automatic Windows and controller startup - #19

Merged
Mamat79 merged 1 commit into
mainfrom
agent/windows-autostart
Aug 10, 2026
Merged

Mamat79 merged 1 commit into
mainfrom
agent/windows-autostart

Conversation

@Mamat79

@Mamat79 Mamat79 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

What changed

  • adds two independent startup options: launch Controller Studio with Windows in the notification area, and automatically connect the selected real-time controller
  • retries EC4 auto-connection silently while MIDI ports become available during server startup
  • shows a localized EC4 waiting screen until LiveProfessor starts sending OSC feedback
  • makes the Live/MIDI/OSC settings buttons fully visible in French and English
  • removes the Windows startup entry during uninstall
  • updates the bilingual README, changelog and both PDF manuals without changing the V.2026.4 version number

Why

A LiveProfessor server should recover after a Windows restart without requiring a manual click on Start, while keeping Windows startup and controller connection separately configurable.

Validation

  • python -m pytest -q — 232 passed
  • python -m compileall -q src
  • git diff --check
  • packaged EXE content inspection passed
  • installed packaged smoke test returned exit code 0
  • visual QA confirmed the startup controls and the full EC4 settings button row

@Mamat79
Mamat79 marked this pull request as ready for review August 10, 2026 20:43
@Mamat79
Mamat79 merged commit 4b614d8 into main Aug 10, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81e9b27ed9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# A reconnect is a new user-visible connection event. Keep the
# one-shot guard inside one connection, but show the banner again.
self._startup_banner_shown = False
self._waiting_for_liveprofessor_displayed = False

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset LiveProfessor feedback when MIDI reconnects

After any OSC packet has been received, _liveprofessor_feedback_received remains true for the lifetime of the runtime. If the EC4 later disconnects and reconnects after LiveProfessor has stopped, this block clears only the displayed-wait flag, so _finish_startup_banner() immediately restores stale parameters rather than showing the new waiting screen. Reset the feedback state and request fresh Companion feedback for each new MIDI connection.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant