Add automatic Windows and controller startup - #19
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 81e9b27ed9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # A reconnect is a new user-visible connection event. Keep the | ||
| # one-shot guard inside one connection, but show the banner again. | ||
| self._startup_banner_shown = False | ||
| self._waiting_for_liveprofessor_displayed = False |
There was a problem hiding this comment.
Reset LiveProfessor feedback when MIDI reconnects
After any OSC packet has been received, _liveprofessor_feedback_received remains true for the lifetime of the runtime. If the EC4 later disconnects and reconnects after LiveProfessor has stopped, this block clears only the displayed-wait flag, so _finish_startup_banner() immediately restores stale parameters rather than showing the new waiting screen. Reset the feedback state and request fresh Companion feedback for each new MIDI connection.
Useful? React with 👍 / 👎.
What changed
Why
A LiveProfessor server should recover after a Windows restart without requiring a manual click on Start, while keeping Windows startup and controller connection separately configurable.
Validation
python -m pytest -q— 232 passedpython -m compileall -q srcgit diff --check