Clear EC4 waiting display on stop - #20
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f548fa534c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self._parameter_overlay_timer.cancel() | ||
| self._parameter_overlay_timer = None | ||
| self._pending_overlay_index = None | ||
| self._clear_display_on_stop() |
There was a problem hiding this comment.
Clear the display after background producers stop
When Stop is pressed while a MIDI connection is completing or an OSC callback is in flight, the display is cleared before _osc_server.stop() and before the reconnect thread is joined. Those paths can subsequently send a startup banner or overlay SysEx, after which the MIDI port closes and leaves that newer screen frozen on the EC4. Quiesce the OSC and reconnect workers first, then send the clear immediately before closing MIDI.
Useful? React with 👍 / 👎.
What changed
By Mamatline from the EC4 LiveProfessor waiting screen while keeping the small ASCII faderWhy
The waiting screen should remain minimal and must not stay frozen on the EC4 after the user presses Stop or fully quits Controller Studio.
Validation
python -m pytest tests/test_bridge.py -q— 33 passedpython -m pytest -q— 233 passedpython -m compileall -q srcgit diff --check