Skip to content

Clear EC4 waiting display on stop - #20

Merged
Mamat79 merged 1 commit into
mainfrom
agent/ec4-stop-clear
Aug 10, 2026
Merged

Mamat79 merged 1 commit into
mainfrom
agent/ec4-stop-clear

Conversation

@Mamat79

@Mamat79 Mamat79 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

What changed

  • removes the By Mamat line from the EC4 LiveProfessor waiting screen while keeping the small ASCII fader
  • sends the EC4 total-display clear SysEx before the MIDI port closes
  • prevents a canceled waiting timer from repainting the screen during shutdown
  • documents the behavior in French and English

Why

The waiting screen should remain minimal and must not stay frozen on the EC4 after the user presses Stop or fully quits Controller Studio.

Validation

  • python -m pytest tests/test_bridge.py -q — 33 passed
  • python -m pytest -q — 233 passed
  • python -m compileall -q src
  • git diff --check
  • packaged EXE content inspection passed
  • packaged smoke test returned exit code 0
  • installed EXE hash matches the rebuilt V.2026.4 binary

@Mamat79
Mamat79 marked this pull request as ready for review August 10, 2026 20:58
@Mamat79
Mamat79 merged commit 55c5148 into main Aug 10, 2026
3 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f548fa534c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

self._parameter_overlay_timer.cancel()
self._parameter_overlay_timer = None
self._pending_overlay_index = None
self._clear_display_on_stop()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear the display after background producers stop

When Stop is pressed while a MIDI connection is completing or an OSC callback is in flight, the display is cleared before _osc_server.stop() and before the reconnect thread is joined. Those paths can subsequently send a startup banner or overlay SysEx, after which the MIDI port closes and leaves that newer screen frozen on the EC4. Quiesce the OSC and reconnect workers first, then send the clear immediately before closing MIDI.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant