Finalize configurable shortcuts and current-project AutoMap in V.2026.5 - #22
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e69663576c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| candidate = Path(os.path.expandvars(raw_path)).expanduser() | ||
| if candidate.is_file() and candidate.suffix.casefold() == ".rack2": | ||
| return candidate.resolve() |
There was a problem hiding this comment.
Do not treat the recent-project entry as the active project
When LiveProfessor is running with a new unsaved project, RecentProjects.xml can still begin with the previous existing .rack2, so this returns that previous file as the currently open project. The subsequent save prompt does not make the workflow safe because _analyze_automap_project continues with the already cached path without detecting again, causing AutoMap to analyze and copy the wrong project. Require an actual active-project signal or re-detect and explicitly confirm the path after the user saves.
Useful? React with 👍 / 👎.
Résumé\n- remplace le bouton EC4 par des raccourcis génériques configurables par contrôleur\n- conserve les raccourcis usine EC4 tout en les rendant modifiables\n- détecte prudemment le projet LiveProfessor actuellement ouvert pour AutoMap, avec avertissement de sauvegarde et copie sûre\n- améliore la netteté du visuel latéral et met à jour les notices FR/EN\n\n## Validation\n- 242 tests réussis\n- compilation Python réussie\n- roue Python construite et contrôlée\n- EXE portable et installeur Inno Setup construits et contrôlés\n- installation locale remplacée; cible et icône du raccourci Bureau vérifiées\n- notices PDF FR/EN rendues et contrôlées visuellement