[WIP] [EXPERIMENT] Don't send kind, apiVersion in create POST#333
Open
cben wants to merge 2 commits intoManageIQ:masterfrom
Open
[WIP] [EXPERIMENT] Don't send kind, apiVersion in create POST#333cben wants to merge 2 commits intoManageIQ:masterfrom
cben wants to merge 2 commits intoManageIQ:masterfrom
Conversation
Can we revert ManageIQ#58? Seems kubernetes/kubernetes#6439 fixed - from which kubernetes version? kubernetes/kubernetes#10200 landed in v1.1.0.
|
i feel like k8s 1.1.0 is old enough that removing |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can we revert #58?
Seems kubernetes/kubernetes#6439 fixed - from which kubernetes version?
kubernetes/kubernetes#10200 landed in v1.1.0.
Works for me on OpenShift 3.10-ish:
(note POST body didn't include kind nor apiVersion)
Motivation: if we don't need to know apiVersion, this may (?) open up #284, #318, and other issues to simpler interface.