Skip to content

[WIP] Fix NetworkManager EventTargetParser - #921

Open
agrare wants to merge 1 commit into
ManageIQ:masterfrom
agrare:fix_network_event_target_parser
Open

[WIP] Fix NetworkManager EventTargetParser#921
agrare wants to merge 1 commit into
ManageIQ:masterfrom
agrare:fix_network_event_target_parser

Conversation

@agrare

@agrare agrare commented Sep 29, 2025

Copy link
Copy Markdown
Member

Some event payload types don't have a resource_id in the payload, but they do have e.g. {"network" => {"id" => ...}}

Ref: https://github.com/orgs/ManageIQ/discussions/23589

@agrare

agrare commented Oct 30, 2025

Copy link
Copy Markdown
Member Author

@Niccolo-Alfredo I wonder if you could help with some examples of other payloads here?

@niccoloalfredo

Copy link
Copy Markdown

Hi @agrare!

Yes, absolutely. I agree that a more complete solution is needed for the Network Manager's target parsing.

I have opened a new Pull Request, #930, which proposes a comprehensive fix and enhancement for the network_manager/event_target_parser.rb.

The PR includes logic to correctly handle various resource targets (like Ports, Security Groups, etc.) from modern OpenStack event payloads, addressing the need for better targeting examples.

Please feel free to review the changes directly in PR #930.

@miq-bot

miq-bot commented Dec 30, 2025

Copy link
Copy Markdown
Member

Checked commit agrare@411aebd with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint
2 files checked, 1 offense detected

app/models/manageiq/providers/openstack/network_manager/event_target_parser.rb

@miq-bot miq-bot added the stale label Apr 6, 2026
@miq-bot

miq-bot commented Apr 6, 2026

Copy link
Copy Markdown
Member

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants