[WIP] Fix NetworkManager EventTargetParser - #921
Conversation
|
@Niccolo-Alfredo I wonder if you could help with some examples of other payloads here? |
|
Hi @agrare! Yes, absolutely. I agree that a more complete solution is needed for the Network Manager's target parsing. I have opened a new Pull Request, #930, which proposes a comprehensive fix and enhancement for the The PR includes logic to correctly handle various resource targets (like Ports, Security Groups, etc.) from modern OpenStack event payloads, addressing the need for better targeting examples. Please feel free to review the changes directly in PR #930. |
|
Checked commit agrare@411aebd with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint app/models/manageiq/providers/openstack/network_manager/event_target_parser.rb
|
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
Some event payload types don't have a
resource_idin the payload, but they do have e.g.{"network" => {"id" => ...}}Ref: https://github.com/orgs/ManageIQ/discussions/23589