Improve sidekiq-scheduler on_post_trigger debug logging - #984
Merged
Merged
Conversation
- Switch on_post_trigger fired breadcrumb to info since debug logging is not enabled in production - Drop the completed breadcrumb — absence of the fired line is sufficient to detect when on_post_trigger stops being called - Rescue Exception instead of StandardError so that non-StandardError exceptions (e.g. Interrupt, NoMemoryError) are also logged before re-raising; these would otherwise kill the work thread silently with no indication of what happened
bdunne
approved these changes
Sep 17, 2026
Member
|
Checked commit Fryguy@0cbdb41 with ruby 3.3.12, rubocop 1.89.0, haml-lint 0.78.0, and yamllint 1.37.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bdunne Please review.