Conversation
This commit allows exec'ing into a specific container within a pod. Before this commit, for multi-container pods, we would automatically default to the first pod. In the case of the queue-worker pod, the default container is queue-worker, and it was not possible to get into queue-worker-glacial container. In most cases this doesn't matter, but in a recent debug session I had to get into queue-worker-glacial to see what was going on from that pod's perspective.
Member
|
Checked commit Fryguy@ef18374 with ruby 3.3.12, rubocop 1.89.0, haml-lint 0.78.0, and yamllint 1.37.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows exec'ing into a specific container within a pod. Before this commit, for multi-container pods, we would automatically default to the first pod. In the case of the queue-worker pod, the default container is queue-worker, and it was not possible to get into queue-worker-glacial container. In most cases this doesn't matter, but in a recent debug session I had to get into queue-worker-glacial to see what was going on from that pod's perspective.
@bdunne Please review.