Repository navigation
log: later discs and series parts survive the log reader - #32
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
After #15, a multi-disc fix.csv uses the same book column for every disc. The processed marker was keyed on that name only, so a later run (or a name-only marker from hybrid) skipped remaining discs. Cache by release+file in log mode. The same reader still rebuilt Audible/MAM series with setSeries, which splits on #; seriesparts is "Name part". Pair series + seriesparts the way #18 already does for the id3 columns. Co-authored-by: Mancolt <Mancolt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Two log-mode reader bugs left after #15 / #18:
Later discs skipped. Each fix.csv row is processed on its own, but the never-expiring
__cache__/bookmarker was keyed only on thebookcolumn. After grouping discs under the release folder, a later run (or a name-only marker from a prior hybrid pass) printedSkipping: … already processedfor every remaining disc.cd2never reached the library.Series part lost. Matched Audible/MAM rows still used
setSeries(seriesparts), which splits on#. The log writesseriespartsasName part. A matched row with a blankedpathscolumn (the documented re-pin workflow) filed asSeries 17.5 - Titleand wrote that name intometadata.opf.Root cause
isCached/cacheMehashedMAMBook.nameonly. Log mode creates oneMAMBookper row (hash("{i}-{book}")) but they share the same name.#18taughtsetSeriesFromLogto pairseries+seriespartsfor the id3 columns; the audible/mam rebuild inbuildTreeFromLogwas not switched over.Fix
cacheKeyto{book}|{fullpath};getHashKeyuses that when present. Hybrid mode is unchanged (still hashes the release name).setSeriesFromLoglike the id3 columns.Validation
Pike Logan 17.5row with blankpathsfiles asPike Logan #17.5 - Titleand the OPF hascalibre:series/series_index.