Repository navigation
mam: do not file another book by the same author - #35
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
MAM search is by filename, so a snatched hit for another book by the same author used to pass the author-only gate whenever the tags did not need parsing. The Guest tagged as James Patterson was filed as Along Came a Spider (token_sort 67, above matchrate 60). Ranking now requires a title match for a non-junk id3/parsed title and applies Config/matchrate. Co-authored-by: Mancolt <Mancolt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAM ranking accepted a different snatched book by the same author when the id3 title and artist were already usable. Search is by filename (
01.mp3,file.m4b), and the author-only gate skipped the title check unless the release name had to supply title or authors.Impact:
The Guesttagged as James Patterson was filed as Along Came a Spider (token_sort 67, abovematchrate60). Typical trigger: a multi-file release whose first file is01.mp3/file.m4b,metadataincludesmam, non-interactive run.Fix: Require a title match whenever the id3/parsed title is not junk, and apply
Config/matchratethe same way_rankAudiblealready does. Author-only remains only for junk/empty titles.Validation:
ParsedAuthorsMamRankingTest(good id3 reject + accept; existing parsed-author cases). Full suite 223 tests OK. Correctness and security review of the diff: no findings.