Repository navigation
mam: do not file another series volume from an unsnatched row - #40
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
samePosition treated two volumes as the same book whenever neither title wrote "Book N", so a Mother of Learning part-1 file could be filed as part 2 (id3 SERIES/PART or a parsed "Author - Title, Book 2" folder). Compare those parts, and apply the parsed folder part when the tags have none. Co-authored-by: Mancolt <Mancolt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
With
mam/accept_unsnatchedon, a series volume whose title does not write "Book N" (the number lives only in id3SERIES/PART, or in a parsed folder such asDomagoj Kurmaic - Mother of Learning, Book 2) was accepted against another volume of the same title with a different MAMseries_infopart. The audio of book 1 could be filed as book 2.samePositionalready refused a title-writtenBook 2against a part-3 row. It returned True whenever both titles lackedBook N, so the series parts were never compared.Root cause
samePositiontreated "neither title writes Book N" as no conflict.applyParsedNamecopies title/authors, not series/part, so a junk-tag file whose folder carried the volume still had nothing forsamePositionto compare.Fix
Book Nbut both books have a series part, require those parts to overlap.pickUnsnatched, apply the parsed folder part when the tags have none.series_infois still accepted (cannot refuse the release's own torrent if MAM omitted the part).Validation
GateTest.test_series_parts_must_agree_when_neither_title_writes_book_n: part 1 vs part 2 is refused; matching parts and2/2.0still accept.GateTest.test_parsed_folder_part_is_used_when_id3_has_no_series_part: junk tags +Author - Title, Book 2refuse MAM part 1/3 and accept part 2.