Skip to content

Fix chat notification deep links #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maneek21 merged 1 commit into from
Jul 21, 2026
Merged

Fix chat notification deep links #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/api/src/routes/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ messageRoutes.post('/:spaceId', async (c) => {
type: 'mention',
title: `${userData?.name ?? 'Someone'} mentioned you`,
body: normalizedContent.slice(0, 200),
link: `/spaces/${spaceId}?message=${message!.id}`,
link: `/chat?space=${encodeURIComponent(spaceId)}&message=${encodeURIComponent(message!.id)}`,
}, { channel: 'chat', spaceId, isMention: true });

if (notification) {
Expand Down Expand Up @@ -543,7 +543,7 @@ messageRoutes.post('/:spaceId', async (c) => {
type: 'mention',
title: `${userData?.name ?? 'Someone'} replied to your message`,
body: normalizedContent.slice(0, 200),
link: `/spaces/${spaceId}?message=${parsed.data.parent_id}`,
link: `/chat?space=${encodeURIComponent(spaceId)}&message=${encodeURIComponent(parsed.data.parent_id)}`,
}, { channel: 'chat', spaceId, isMention: true });

if (notification) {
Expand Down
2 changes: 1 addition & 1 deletion apps/api/src/workers/handlers/blocked-alert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export async function handleBlockedAlert(job: JobData): Promise<void> {
type: 'agent_suggestion',
title: 'Blocked Team Member',
body: message,
link: `/spaces/${spaceId}?message=${messageId}`,
link: `/chat?space=${encodeURIComponent(spaceId)}&message=${encodeURIComponent(messageId)}`,
metadata: {
task_id: task.id,
nudge_type: 'blocked',
Expand Down
15 changes: 15 additions & 0 deletions apps/api/test/agent-mention-detection.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,21 @@ test('structured mention of Defty user triggers agent-reply dispatch', async ()
assert.ok(body.id, 'response should include message id');
createdMessageIds.push(body.id!);

const [mentionNotification] = await db
.select({ link: notifications.link })
.from(notifications)
.where(and(
eq(notifications.user_id, deftyUserId),
eq(notifications.type, 'mention'),
eq(notifications.link, `/chat?space=${spaceId}&message=${body.id}`),
))
.limit(1);
assert.equal(
mentionNotification?.link,
`/chat?space=${spaceId}&message=${body.id}`,
'mention notification should deep-link to the message on the chat surface',
);

const dispatched = await findAgentReplyJob(body.id!);
assert.ok(dispatched, 'agent-reply job should be enqueued for Defty mention');
const employeeQueued = await findAgentEmployeeMessageJob(body.id!);
Expand Down