MISTS: add EXP_MISTS expansion + guard arms for MoP (Four) DBC field renames

[MadMaxMangos]

Summary

Introduces the EXP_MISTS expansion to Eluna and adds MISTS guard arms so the Four (MoP 5.4.8) server can compile Eluna as a distinct expansion and align its core DBC struct fields to the build-exact client names. Purely additive for every other fork: the new expansion value is strictly greater than EXP_CATA, ordered comparisons (>= EXP_CATA, < EXP_CATA, …) already classify it correctly, and the guard-arm insertions never modify a non-MISTS branch.

What changed

1. ElunaUtility.h — #define EXP_MISTS 4 (after EXP_CATA 3). This lets a mangos-MoP build define ELUNA_EXPANSION=4 instead of masquerading as EXP_CATA.
2. CATA-era == EXP_CATA conditionals — the handful of equality checks in the mangos-compiled surface that gate "Cata-and-later" behavior were widened == EXP_CATA → >= EXP_CATA so MoP keeps that behavior. This is additive: value 3 still matches, 4 newly matches, 0/1/2 still don't — no other fork is affected. (CMangos-only equality sites were left as-is; they don't compile for mangos and aren't MoP's to change.)
3. Guard arms for the DBC fields MoP renamed, each inserted before the existing #else (CATA) arm as #elif defined(ELUNA_MANGOS) && ELUNA_EXPANSION == EXP_MISTS (or MISTS added to an existing new-name #if group). Fields: AreaTable area_name→AreaName_lang; AreaTrigger id→ID (hooks/ServerHooks.cpp + hooks/CreatureHooks.cpp spell Id→ID); AuctionHouse houseId→ID; ChrClasses/ChrRaces name→Name_lang; ItemRandomProperties/ItemRandomSuffix nameSuffix→Name_lang; SkillLine categoryId→CategoryID,id→ID; Spell Id→ID; TaxiNodes map_id→ContinentID; TaxiPath from/to/price→FromTaxiNode/ToTaxiNode/Cost; TaxiPathNode mapid/actionFlag/delay/path/index→ContinentID/Flags/Delay/PathID/NodeIndex; Vehicle m_ID→ID.

Cross-fork safety

Every non-MISTS branch is byte-identical to base (raw autocrlf-off diff audited; CRLF preserved, no whole-file line-ending churn). The ELUNA_MANGOS gate is kept on every arm so non-mangos cores (which see ELUNA_EXPANSION==0) never take a MoP path. Verified by an adversarial cross-fork review.

Prerequisite note for the mangos build

A mangos-MoP core must define ELUNA_EXPANSION=4 (the Four core PR does this in src/{game,mangosd,shared}/CMakeLists.txt). Without EXP_MISTS, such a build previously had to compile Eluna as EXP_CATA=3.

Land order

Companion to the Four core PR and the SD3 MISTS PR. Merge this + SD3 first, then the core PR re-points its submodule pointers to the merged masters. Base pin: current Eluna master (18ff8fb8).

---

This change is 

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea387b6458

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Keep MISTS on the existing MaNGOS DBC names

For a Mangos Four/EXP_MISTS build, this arm selects AreaTriggerEntry::ID, but the current Four DBC struct still exposes the member as id (and the same lower-case naming is used for related structs such as AreaTableEntry::area_name and AuctionHouseEntry::houseId in src/game/Server/DBCStructure.h). Because this branch is compiled only when the new expansion value is used, the MoP target fails to compile unless the companion core has actually renamed those DBC fields; otherwise the MISTS arm should keep using the existing lower-case MaNGOS member names.

Useful? React with 👍 / 👎.

[MadMaxMangos]

This is the intended cross-repo coupling, not a mismatch. The companion Four core PR renames these DBC fields to their client-exact names — AreaTriggerEntry::id → ID, AreaTableEntry::area_name → AreaName_lang, AuctionHouseEntry::houseId → ID — so the EXP_MISTS arms here (pTrigger->ID, …) resolve against the renamed core. The three PRs land as one bundle (SD3 + Eluna first, then the core re-points its submodule pins), and Eluna already compiles+links against the renamed core in that configuration. Keeping the legacy lower-case names in the MISTS arm would instead break the MoP build.

[chatgpt-codex-connector]

Handle MISTS in the remaining CATA-only guards

Defining a distinct EXP_MISTS value means a MoP build no longer compiles as EXP_CATA, but several Mangos code paths still select Cata APIs only via #ifdef CATA; for example methods/Mangos/PlayerMethods.h still falls through to player->resetTalentsCost() instead of the Cata/MoP GetNextResetTalentsCost() path when only MISTS is defined. Those remaining CATA-only guards need the same MISTS coverage as the widened ELUNA_EXPANSION >= EXP_CATA checks, otherwise the new expansion target continues to compile against pre-Cata APIs.

Useful? React with 👍 / 👎.

[MadMaxMangos]

Confirmed and fixed. A MoP build defines MISTS (via MANGOS_EXP), never CATA, so the two remaining #ifdef CATA API guards fell through to the pre-Cata #else: ResetTalentsCost (PlayerMethods.h) and GetEndTime (BattleGroundMethods.h). Widened both to #if defined(CATA) || defined(MISTS) in 32740c7. Both Cata+ APIs (GetNextResetTalentsCost, GetRemainingTime) exist in the Four core, and an incremental build confirms the MISTS arms compile+link. A full sweep of the compiled Eluna surface found these were the only two such sites. (Pre-existing gap — MANGOS_EXP=MISTS predates this branch — but the fix belongs here.)