Skip to content

Fix/mop group marker context 18414 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MadMaxMangos wants to merge 2 commits into from
Closed

Fix/mop group marker context 18414 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd0b208
mop: route auction menu through session sender
MadMaxMangos Jul 21, 2026
9a88d15
fix(mangos-mists): Group:SetTargetIcon 4-arg call for MoP raid markers
MadMaxMangos Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions methods/Mangos/GroupMethods.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,10 @@ namespace LuaGroup

#if (defined(CLASSIC) || defined(TBC))
group->SetTargetIcon(icon, target);
#elif defined(ELUNA_MANGOS) && ELUNA_EXPANSION == EXP_MISTS
// MoP (mangos-four) restored raid markers with a fourth "context" argument on
// Group::SetTargetIcon; 0 selects a normal target-icon set (see GroupHandler).
group->SetTargetIcon(icon, setter, target, 0);

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep MoP SetTargetIcon at three arguments

When building against the mangos-four 0.17 / 18414 core, Group::SetTargetIcon is declared and called by GroupHandler with three parameters (uint8, ObjectGuid, ObjectGuid), so this MoP-only four-argument call has no matching overload and prevents the supported MoP target from compiling. Please keep the MoP branch on the existing (icon, setter, target) call unless it is guarded for a core revision that actually has the context parameter.

Useful? React with 👍 / 👎.

#else
group->SetTargetIcon(icon, setter, target);
#endif
Expand Down
6 changes: 4 additions & 2 deletions methods/Mangos/PlayerMethods.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2072,6 +2072,9 @@ namespace LuaPlayer
{
Unit* unit = E->CHECKOBJ<Unit>(2);

#if defined(ELUNA_MANGOS) && ELUNA_EXPANSION == EXP_MISTS
player->GetSession()->SendAuctionHello(unit);
#else
AuctionHouseEntry const* ahEntry = AuctionHouseMgr::GetAuctionHouseEntry(unit);
if (!ahEntry)
return 0;
Expand All @@ -2080,14 +2083,13 @@ namespace LuaPlayer
data << unit->GET_GUID();
#if defined(ELUNA_MANGOS) && ELUNA_EXPANSION == EXP_TBC
data << uint32(ahEntry->ID);
#elif defined(ELUNA_MANGOS) && ELUNA_EXPANSION == EXP_MISTS
data << uint32(ahEntry->ID);
#else
data << uint32(ahEntry->houseId);
#endif
data << uint8(1);

player->GetSession()->SendPacket(&data);
#endif
return 0;
}

Expand Down
Loading