Fix transfer function textures with new renderer use#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the point renderer now handles navigation and translating world to screen coordinates a bit differently than was the case when this plugin was first implemented, the selections made in the transfer function plugin are now a bit offset.
Here we introduce some ROI transformation and small speed-ups in transfer function generation.
This fix does not yet account for view port changes due to navigation or widget resizing.Since we use_pointRenderer->getScreenPointToWorldPositionwhich already takes into account widget resizing and navigation changes this actually does work - I just hadn't tested it for the PR and assumed it would not.