add fail_fast option #792
Open
add fail_fast option #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a fail_fast configuration option to AlphaDIA that controls error handling behavior during file processing. When enabled, the system will immediately stop execution upon encountering an error instead of logging it and continuing with remaining files.
Changes:
- Added
fail_fastconfiguration option to control whether processing stops immediately on errors - Updated error handling logic to raise exceptions immediately when
fail_fastis enabled - Added documentation explaining the new error handling behavior and usage
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| alphadia/constants/default.yaml | Added fail_fast configuration parameter with default value of False |
| alphadia/search_step.py | Implemented fail-fast logic to raise exceptions immediately when enabled |
| docs/methods/command-line.md | Added documentation section explaining error handling behavior and the new option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alphadia/constants/default.yaml
Outdated
| # if null, no specific setting of random states is performed | ||
| random_state: null | ||
|
|
||
| # if true, exit immediately in case a file raises an error. If set to False, errors will be logged but the processing of other files will continue. |
There was a problem hiding this comment.
Corrected 'hand' to 'handy' in the PR description, but the comment here uses 'if set to False' which should be 'If set to false' for consistency with the lowercase boolean value format used in YAML.
Suggested change
| # if true, exit immediately in case a file raises an error. If set to False, errors will be logged but the processing of other files will continue. | |
| # if true, exit immediately in case a file raises an error. If set to false, errors will be logged but the processing of other files will continue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fail_fast option (hand for benchmarking and debugging)