fix(AutoComplete): support IconField iconPosition - #370
Merged
Conversation
github-actions
Bot
added
the
Status: Needs Triage
sja-cslab
marked this pull request as ready for review
July 17, 2026 08:39
sja-cslab
added
bug
Member
Author
|
PR originally created by @KumJungMin Agent migrated the old one so we can use it in Mantle UI |
melloware
previously approved these changes
Jul 17, 2026
melloware
reviewed
Jul 17, 2026
Collaborator
|
@KumJungMin would love to have you involved in this project! |
melloware
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iconPositioninAutoCompletedefault propsIconField's injectediconPositionprop from reaching a DOM elementRoot cause
IconFieldclones its child and suppliesiconPosition. UnlikeInputText,AutoCompletedid not consume this inherited prop, so React emitted an unknown DOM-property warning. The legacy themes also targeted only direct.p-inputtextchildren, which excluded AutoComplete's nested input.Provenance
Migrates primefaces/primereact#7447 in full.
Created By: @KumJungMin
Fixes #218
Validation
git diff --binary <upstream-base> <upstream-head> -- components/lib/autocomplete/AutoCompleteBase.js public/themes | git apply --reverse --checknpx eslint components/lib/autocomplete/AutoCompleteBase.jsgit diff --check